From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:54976 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731341AbeGQNYZ (ORCPT ); Tue, 17 Jul 2018 09:24:25 -0400 From: Laurent Pinchart To: kieran.bingham+renesas@ideasonboard.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 10/11] media: vsp1: Support Interlaced display pipelines Date: Tue, 17 Jul 2018 15:52:24 +0300 Message-ID: <5111021.qdhzlld4I3@avalon> In-Reply-To: References: <2663986.uvcnutGSNp@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, On Monday, 16 July 2018 21:21:00 EEST Kieran Bingham wrote: > On 24/05/18 13:51, Laurent Pinchart wrote: > > On Thursday, 3 May 2018 16:36:21 EEST Kieran Bingham wrote: > >> Calculate the top and bottom fields for the interlaced frames and > >> utilise the extended display list command feature to implement the > >> auto-field operations. This allows the DU to update the VSP2 registers > >> dynamically based upon the currently processing field. > >> > >> Signed-off-by: Kieran Bingham > >> > >> --- > >> > >> v3: > >> - Pass DL through partition calls to allow autocmd's to be retrieved > >> - Document interlaced field in struct vsp1_du_atomic_config > >> > >> v2: > >> - fix erroneous BIT value which enabled interlaced > >> - fix field handling at frame_end interrupt > >> > >> --- > >> > >> drivers/media/platform/vsp1/vsp1_dl.c | 10 ++++- > >> drivers/media/platform/vsp1/vsp1_drm.c | 11 ++++- > >> drivers/media/platform/vsp1/vsp1_regs.h | 1 +- > >> drivers/media/platform/vsp1/vsp1_rpf.c | 71 ++++++++++++++++++++++++-- > >> drivers/media/platform/vsp1/vsp1_rwpf.h | 1 +- > >> include/media/vsp1.h | 2 +- > >> 6 files changed, 93 insertions(+), 3 deletions(-) [snip] > >> diff --git a/drivers/media/platform/vsp1/vsp1_drm.c > >> b/drivers/media/platform/vsp1/vsp1_drm.c index 2c3db8b8adce..cc29c9d96bb7 > >> 100644 > >> --- a/drivers/media/platform/vsp1/vsp1_drm.c > >> +++ b/drivers/media/platform/vsp1/vsp1_drm.c > >> @@ -811,6 +811,17 @@ int vsp1_du_atomic_update(struct device *dev, > >> unsigned > >> int pipe_index, return -EINVAL; > >> > >> } > >> > >> + if (!(vsp1_feature(vsp1, VSP1_HAS_EXT_DL)) && cfg->interlaced) { > > > > Nitpicking, writing the condition as > > > > if (cfg->interlaced && !(vsp1_feature(vsp1, VSP1_HAS_EXT_DL))) > > Done. > > > would match the comment better. You can also drop the parentheses around > > the vsp1_feature() call. > > > >> + /* > >> + * Interlaced support requires extended display lists to > >> + * provide the auto-fld feature with the DU. > >> + */ > >> + dev_dbg(vsp1->dev, "Interlaced unsupported on this output\n"); > > > > Could we catch this in the DU driver to fail atomic test ? > > Ugh - I thought moving the configuration to vsp1_du_setup_lif() would > give us this, but that return value is not checked in the DU. > > How can we interogate the VSP1 to ask it if it supports interlaced from > rcar_du_vsp_plane_atomic_check()? > > > Some dummy call to vsp1_du_setup_lif() to check the return value ? Or > should we implement a hook to call through to perform checks in the VSP1 > DRM API? Would it be possible to just infer that from the DU compatible string, without querying the VSP driver ? Of course that's a bit of a layering violation, but as we know what type of VSP instance is present in each SoC, such a small hack wouldn't hurt in my opinion. If the need arises later we can introduce an API to query the information from the VSP driver. > >> + return -EINVAL; > >> + } > >> + > >> + rpf->interlaced = cfg->interlaced; > >> + > >> rpf->fmtinfo = fmtinfo; > >> rpf->format.num_planes = fmtinfo->planes; > >> rpf->format.plane_fmt[0].bytesperline = cfg->pitch; [snip] -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 10/11] media: vsp1: Support Interlaced display pipelines Date: Tue, 17 Jul 2018 15:52:24 +0300 Message-ID: <5111021.qdhzlld4I3@avalon> References: <2663986.uvcnutGSNp@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id B3FE46E704 for ; Tue, 17 Jul 2018 12:51:53 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: kieran.bingham+renesas@ideasonboard.com Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKT24gTW9uZGF5LCAxNiBKdWx5IDIwMTggMjE6MjE6MDAgRUVTVCBLaWVyYW4g QmluZ2hhbSB3cm90ZToKPiBPbiAyNC8wNS8xOCAxMzo1MSwgTGF1cmVudCBQaW5jaGFydCB3cm90 ZToKPiA+IE9uIFRodXJzZGF5LCAzIE1heSAyMDE4IDE2OjM2OjIxIEVFU1QgS2llcmFuIEJpbmdo YW0gd3JvdGU6Cj4gPj4gQ2FsY3VsYXRlIHRoZSB0b3AgYW5kIGJvdHRvbSBmaWVsZHMgZm9yIHRo ZSBpbnRlcmxhY2VkIGZyYW1lcyBhbmQKPiA+PiB1dGlsaXNlIHRoZSBleHRlbmRlZCBkaXNwbGF5 IGxpc3QgY29tbWFuZCBmZWF0dXJlIHRvIGltcGxlbWVudCB0aGUKPiA+PiBhdXRvLWZpZWxkIG9w ZXJhdGlvbnMuIFRoaXMgYWxsb3dzIHRoZSBEVSB0byB1cGRhdGUgdGhlIFZTUDIgcmVnaXN0ZXJz Cj4gPj4gZHluYW1pY2FsbHkgYmFzZWQgdXBvbiB0aGUgY3VycmVudGx5IHByb2Nlc3NpbmcgZmll bGQuCj4gPj4gCj4gPj4gU2lnbmVkLW9mZi1ieTogS2llcmFuIEJpbmdoYW0gPGtpZXJhbi5iaW5n aGFtK3JlbmVzYXNAaWRlYXNvbmJvYXJkLmNvbT4KPiA+PiAKPiA+PiAtLS0KPiA+PiAKPiA+PiB2 MzoKPiA+PiAgLSBQYXNzIERMIHRocm91Z2ggcGFydGl0aW9uIGNhbGxzIHRvIGFsbG93IGF1dG9j bWQncyB0byBiZSByZXRyaWV2ZWQKPiA+PiAgLSBEb2N1bWVudCBpbnRlcmxhY2VkIGZpZWxkIGlu IHN0cnVjdCB2c3AxX2R1X2F0b21pY19jb25maWcKPiA+PiAKPiA+PiB2MjoKPiA+PiAgLSBmaXgg ZXJyb25lb3VzIEJJVCB2YWx1ZSB3aGljaCBlbmFibGVkIGludGVybGFjZWQKPiA+PiAgLSBmaXgg ZmllbGQgaGFuZGxpbmcgYXQgZnJhbWVfZW5kIGludGVycnVwdAo+ID4+IAo+ID4+IC0tLQo+ID4+ IAo+ID4+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9kbC5jICAgfCAxMCArKysr LQo+ID4+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9kcm0uYyAgfCAxMSArKysr LQo+ID4+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9yZWdzLmggfCAgMSArLQo+ ID4+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9ycGYuYyAgfCA3MSArKysrKysr KysrKysrKysrKysrKysrKystLQo+ID4+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNw MV9yd3BmLmggfCAgMSArLQo+ID4+ICBpbmNsdWRlL21lZGlhL3ZzcDEuaCAgICAgICAgICAgICAg ICAgICAgfCAgMiArLQo+ID4+ICA2IGZpbGVzIGNoYW5nZWQsIDkzIGluc2VydGlvbnMoKyksIDMg ZGVsZXRpb25zKC0pCgpbc25pcF0KCj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxh dGZvcm0vdnNwMS92c3AxX2RybS5jCj4gPj4gYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEv dnNwMV9kcm0uYyBpbmRleCAyYzNkYjhiOGFkY2UuLmNjMjljOWQ5NmJiNwo+ID4+IDEwMDY0NAo+ ID4+IC0tLSBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2RybS5jCj4gPj4gKysr IGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZHJtLmMKPiA+PiBAQCAtODExLDYg KzgxMSwxNyBAQCBpbnQgdnNwMV9kdV9hdG9taWNfdXBkYXRlKHN0cnVjdCBkZXZpY2UgKmRldiwK PiA+PiB1bnNpZ25lZAo+ID4+IGludCBwaXBlX2luZGV4LCByZXR1cm4gLUVJTlZBTDsKPiA+PiAK PiA+PiAgCX0KPiA+PiAKPiA+PiArCWlmICghKHZzcDFfZmVhdHVyZSh2c3AxLCBWU1AxX0hBU19F WFRfREwpKSAmJiBjZmctPmludGVybGFjZWQpIHsKPiA+IAo+ID4gTml0cGlja2luZywgd3JpdGlu ZyB0aGUgY29uZGl0aW9uIGFzCj4gPiAKPiA+IAlpZiAoY2ZnLT5pbnRlcmxhY2VkICYmICEodnNw MV9mZWF0dXJlKHZzcDEsIFZTUDFfSEFTX0VYVF9ETCkpKQo+IAo+IERvbmUuCj4gCj4gPiB3b3Vs ZCBtYXRjaCB0aGUgY29tbWVudCBiZXR0ZXIuIFlvdSBjYW4gYWxzbyBkcm9wIHRoZSBwYXJlbnRo ZXNlcyBhcm91bmQKPiA+IHRoZSB2c3AxX2ZlYXR1cmUoKSBjYWxsLgo+ID4gCj4gPj4gKwkJLyoK PiA+PiArCQkgKiBJbnRlcmxhY2VkIHN1cHBvcnQgcmVxdWlyZXMgZXh0ZW5kZWQgZGlzcGxheSBs aXN0cyB0bwo+ID4+ICsJCSAqIHByb3ZpZGUgdGhlIGF1dG8tZmxkIGZlYXR1cmUgd2l0aCB0aGUg RFUuCj4gPj4gKwkJICovCj4gPj4gKwkJZGV2X2RiZyh2c3AxLT5kZXYsICJJbnRlcmxhY2VkIHVu c3VwcG9ydGVkIG9uIHRoaXMgb3V0cHV0XG4iKTsKPiA+IAo+ID4gQ291bGQgd2UgY2F0Y2ggdGhp cyBpbiB0aGUgRFUgZHJpdmVyIHRvIGZhaWwgYXRvbWljIHRlc3QgPwo+IAo+IFVnaCAtIEkgdGhv dWdodCBtb3ZpbmcgdGhlIGNvbmZpZ3VyYXRpb24gdG8gdnNwMV9kdV9zZXR1cF9saWYoKSB3b3Vs ZAo+IGdpdmUgdXMgdGhpcywgYnV0IHRoYXQgcmV0dXJuIHZhbHVlIGlzIG5vdCBjaGVja2VkIGlu IHRoZSBEVS4KPiAKPiBIb3cgY2FuIHdlIGludGVyb2dhdGUgdGhlIFZTUDEgdG8gYXNrIGl0IGlm IGl0IHN1cHBvcnRzIGludGVybGFjZWQgZnJvbQo+IHJjYXJfZHVfdnNwX3BsYW5lX2F0b21pY19j aGVjaygpPwo+IAo+IAo+IFNvbWUgZHVtbXkgY2FsbCB0byB2c3AxX2R1X3NldHVwX2xpZigpIHRv IGNoZWNrIHRoZSByZXR1cm4gdmFsdWUgPyBPcgo+IHNob3VsZCB3ZSBpbXBsZW1lbnQgYSBob29r IHRvIGNhbGwgdGhyb3VnaCB0byBwZXJmb3JtIGNoZWNrcyBpbiB0aGUgVlNQMQo+IERSTSBBUEk/ CgpXb3VsZCBpdCBiZSBwb3NzaWJsZSB0byBqdXN0IGluZmVyIHRoYXQgZnJvbSB0aGUgRFUgY29t cGF0aWJsZSBzdHJpbmcsIHdpdGhvdXQgCnF1ZXJ5aW5nIHRoZSBWU1AgZHJpdmVyID8gT2YgY291 cnNlIHRoYXQncyBhIGJpdCBvZiBhIGxheWVyaW5nIHZpb2xhdGlvbiwgYnV0IAphcyB3ZSBrbm93 IHdoYXQgdHlwZSBvZiBWU1AgaW5zdGFuY2UgaXMgcHJlc2VudCBpbiBlYWNoIFNvQywgc3VjaCBh IHNtYWxsIGhhY2sgCndvdWxkbid0IGh1cnQgaW4gbXkgb3Bpbmlvbi4gSWYgdGhlIG5lZWQgYXJp c2VzIGxhdGVyIHdlIGNhbiBpbnRyb2R1Y2UgYW4gQVBJIAp0byBxdWVyeSB0aGUgaW5mb3JtYXRp b24gZnJvbSB0aGUgVlNQIGRyaXZlci4KCj4gPj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gPj4gKwl9 Cj4gPj4gKwo+ID4+ICsJcnBmLT5pbnRlcmxhY2VkID0gY2ZnLT5pbnRlcmxhY2VkOwo+ID4+ICsK PiA+PiAgCXJwZi0+Zm10aW5mbyA9IGZtdGluZm87Cj4gPj4gIAlycGYtPmZvcm1hdC5udW1fcGxh bmVzID0gZm10aW5mby0+cGxhbmVzOwo+ID4+ICAJcnBmLT5mb3JtYXQucGxhbmVfZm10WzBdLmJ5 dGVzcGVybGluZSA9IGNmZy0+cGl0Y2g7Cgpbc25pcF0KCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQ aW5jaGFydAoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK