Re: [PATCH 0/2] tty: metag_da: fix flipping after tty changes

[Jiri Slaby <jslaby@suse.cz>]

On 02/05/2013 03:40 PM, James Hogan wrote:
> The first patch fixes up tty/metag_da after Jiri's changes, "TTY: switch
> tty_flip_buffer_push" and "TTY: convert more flipping functions",
> switched tty_flip_buffer_push() and tty_prepare_flip_string() to take
> tty_port rather than a tty_struct.
> 
> The second just refactors slightly as a result of it.
> 
> How is this sort of thing usually handled? I suppose either I squash it
> into the original driver and base it on tty-next, move it into tty-next,
> or just fix it up afterwards?
> 
> James Hogan (2):
>   tty: metag_da: update flip functions to use tty_port
>   tty: metag_da: avoid getting tty kref in dashtty_timer()

They both look good. You can add my:
Acked-by: Jiri Slaby <jslaby@suse.cz>
if you want.

thanks,
-- 
js
suse labs