From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Wise Subject: Re: infiniband: cxgb4: GCC warnings for 32 bit Date: Tue, 05 Feb 2013 10:45:55 -0600 Message-ID: <51113743.6050403@opengridcomputing.com> References: <1360059358.1343.37.camel@x61.thuisdomein> <51112943.3040003@opengridcomputing.com> <1360082216.14826.17.camel@x61.thuisdomein> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1360082216.14826.17.camel-uMdlDhfIn7prKue/0VVhAg@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Paul Bolle Cc: Steve Wise , Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vipul Pandya List-Id: linux-rdma@vger.kernel.org On 2/5/2013 10:36 AM, Paul Bolle wrote: > On Tue, 2013-02-05 at 09:46 -0600, Steve Wise wrote: >> On 2/5/2013 4:15 AM, Paul Bolle wrote: >>> And why is 'cookie' __u64? Is struct cpl_fw6_msg_ofld_connection_wr_rpl >>> used in userspace code? Can't 'cookie' be of type "struct sk_buff *"? Is >>> there a requirement for it to be 64 bits wide on both 32 bit and 64 bit? >> In general, these fields are __ types to highlight the fact that they >> define an interface between the host driver and adapter firmware. > That's something new for me. Is that a custom for infiniband drivers or > is it used throughout the tree? I'm not too sure how standardized this is. I think its SOP for Chelsio drivers. :) >> These >> "cookie" fields are opaque to the firmware. They are passed to firmware >> in a work request and then reflected back to the host in the reply to >> the work request. Given this, I think there are two issues: >> >> 1) no swapping is really needed. The values are opaque to firmware, and >> thus can stay in host byte order. >> >> 2) to remove the warning, we need something like: >> >> req->cookie = (unsigned long)skb; >> >> and >> >> rpl_skb = (struct sk_buff *)(unsigned long)req->cookie; > That's is exactly what I came up with to silence these warnings. But I > didn't dare to submit it because I was too puzzled with the current > code. Anyhow, should I submit the (trivial) patch to fix this? Sure. Thanks. Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755462Ab3BEQps (ORCPT ); Tue, 5 Feb 2013 11:45:48 -0500 Received: from smtp.opengridcomputing.com ([72.48.136.20]:48681 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754742Ab3BEQpq (ORCPT ); Tue, 5 Feb 2013 11:45:46 -0500 Message-ID: <51113743.6050403@opengridcomputing.com> Date: Tue, 05 Feb 2013 10:45:55 -0600 From: Steve Wise User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Paul Bolle CC: Steve Wise , Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Vipul Pandya Subject: Re: infiniband: cxgb4: GCC warnings for 32 bit References: <1360059358.1343.37.camel@x61.thuisdomein> <51112943.3040003@opengridcomputing.com> <1360082216.14826.17.camel@x61.thuisdomein> In-Reply-To: <1360082216.14826.17.camel@x61.thuisdomein> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/5/2013 10:36 AM, Paul Bolle wrote: > On Tue, 2013-02-05 at 09:46 -0600, Steve Wise wrote: >> On 2/5/2013 4:15 AM, Paul Bolle wrote: >>> And why is 'cookie' __u64? Is struct cpl_fw6_msg_ofld_connection_wr_rpl >>> used in userspace code? Can't 'cookie' be of type "struct sk_buff *"? Is >>> there a requirement for it to be 64 bits wide on both 32 bit and 64 bit? >> In general, these fields are __ types to highlight the fact that they >> define an interface between the host driver and adapter firmware. > That's something new for me. Is that a custom for infiniband drivers or > is it used throughout the tree? I'm not too sure how standardized this is. I think its SOP for Chelsio drivers. :) >> These >> "cookie" fields are opaque to the firmware. They are passed to firmware >> in a work request and then reflected back to the host in the reply to >> the work request. Given this, I think there are two issues: >> >> 1) no swapping is really needed. The values are opaque to firmware, and >> thus can stay in host byte order. >> >> 2) to remove the warning, we need something like: >> >> req->cookie = (unsigned long)skb; >> >> and >> >> rpl_skb = (struct sk_buff *)(unsigned long)req->cookie; > That's is exactly what I came up with to silence these warnings. But I > didn't dare to submit it because I was too puzzled with the current > code. Anyhow, should I submit the (trivial) patch to fix this? Sure. Thanks. Steve.