From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, qca_vkondrat@qca.qualcomm.com,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] mac80211: provide 64-bit traffic counters
Date: Tue, 05 Feb 2013 09:21:28 -0800 [thread overview]
Message-ID: <51113F98.8040209@candelatech.com> (raw)
In-Reply-To: <1360058204-12208-1-git-send-email-johannes@sipsolutions.net>
On 02/05/2013 01:56 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> "unsigned long" is already 64-bit on (most?) 64-bit
> machines, use u64 and tell cfg80211 that we provide
> 64-bit counters now.
From what I can tell, these counters are modified using
+= operators. From what I recall, this is non-atomic on
32-bit systems when the variable is u64.
Is there any other locking that keeps this from blowing up?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2013-02-05 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 9:56 [PATCH] mac80211: provide 64-bit traffic counters Johannes Berg
2013-02-05 17:21 ` Ben Greear [this message]
2013-02-05 17:24 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51113F98.8040209@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=qca_vkondrat@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.