From: Gabor Juhos <juhosg-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH 6/6] spi/ath79: add shutdown handler
Date: Tue, 05 Feb 2013 20:53:12 +0100 [thread overview]
Message-ID: <51116328.7000907@openwrt.org> (raw)
In-Reply-To: <20130205130207.39E9F3E0E30@localhost>
2013.02.05. 14:02 keltezéssel, Grant Likely írta:
>> -static int ath79_spi_remove(struct platform_device *pdev)
>> +static void __ath79_spi_remove(struct platform_device *pdev)
>> {
>> struct ath79_spi *sp = platform_get_drvdata(pdev);
>>
>> @@ -304,13 +304,23 @@ static int ath79_spi_remove(struct platform_device *pdev)
>> iounmap(sp->base);
>> platform_set_drvdata(pdev, NULL);
>> spi_master_put(sp->bitbang.master);
>> +}
>>
>> +static int ath79_spi_remove(struct platform_device *pdev)
>> +{
>> + __ath79_spi_remove(pdev);
>> return 0;
>> }
>>
>> +static void ath79_spi_shutdown(struct platform_device *pdev)
>> +{
>> + __ath79_spi_remove(pdev);
>> +}
>
> Just call ath79_spi_remote(pdev) directly from ath79_spi_shutdown(). No
> need for the extra hook and __ version of the original function.
Ok, I will send a modified patch.
Thanks,
Gabor
------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
prev parent reply other threads:[~2013-02-05 19:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-27 9:42 [PATCH 0/6] spi/ath79: various fixes Gabor Juhos
[not found] ` <1356601349-23617-1-git-send-email-juhosg-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-12-27 9:42 ` [PATCH 1/6] spi/ath79: add delay between SCK changes Gabor Juhos
[not found] ` <1356601349-23617-2-git-send-email-juhosg-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2013-02-05 12:57 ` Grant Likely
2013-02-05 19:52 ` Gabor Juhos
2012-12-27 9:42 ` [PATCH 2/6] spi/ath79: add missing HIGH->LOW SCK transition Gabor Juhos
[not found] ` <1356601349-23617-3-git-send-email-juhosg-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2013-02-05 12:57 ` Grant Likely
2012-12-27 9:42 ` [PATCH 3/6] spi/ath79: remove superfluous chip select code Gabor Juhos
[not found] ` <1356601349-23617-4-git-send-email-juhosg-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2013-02-05 12:58 ` Grant Likely
2012-12-27 9:42 ` [PATCH 4/6] spi/ath79: use gpio_request_one Gabor Juhos
[not found] ` <1356601349-23617-5-git-send-email-juhosg-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2013-02-05 12:59 ` Grant Likely
2012-12-27 9:42 ` [PATCH 5/6] spi/ath79: avoid multiple initialization of the SPI controller Gabor Juhos
[not found] ` <1356601349-23617-6-git-send-email-juhosg-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2013-02-05 13:00 ` Grant Likely
2012-12-27 9:42 ` [PATCH 6/6] spi/ath79: add shutdown handler Gabor Juhos
[not found] ` <1356601349-23617-7-git-send-email-juhosg-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2013-02-05 13:02 ` Grant Likely
2013-02-05 19:53 ` Gabor Juhos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51116328.7000907@openwrt.org \
--to=juhosg-p3rkhjxn3npafugrpc6u6w@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.