All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 3/4] imx: mx5: lowlevel_init: Simplify code
Date: Wed, 06 Feb 2013 09:56:19 +0100	[thread overview]
Message-ID: <51121AB3.3000700@denx.de> (raw)
In-Reply-To: <1360098435-26005-3-git-send-email-benoit.thebaudeau@advansee.com>

On 05/02/2013 22:07, Beno?t Th?baudeau wrote:
> Don't use several instructions to build constant values.
> 
> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> ---
> Changes in v3:
>  - New patch.
> 
> Changes in v2: None
> 
>  arch/arm/cpu/armv7/mx5/lowlevel_init.S |    8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/mx5/lowlevel_init.S b/arch/arm/cpu/armv7/mx5/lowlevel_init.S
> index 6d9396a..dfce0ca 100644
> --- a/arch/arm/cpu/armv7/mx5/lowlevel_init.S
> +++ b/arch/arm/cpu/armv7/mx5/lowlevel_init.S
> @@ -309,8 +309,7 @@ setup_pll_func:
>          ldr r0, =CCM_BASE_ADDR
>          ldr r1, =0x00015154
>          str r1, [r0, #CLKCTL_CBCMR]
> -        ldr r1, =0x02888945
> -        orr r1, r1, #(1 << 16)
> +        ldr r1, =0x02898945
>          str r1, [r0, #CLKCTL_CBCDR]
>          /* make sure change is effective */
>  1:      ldr r1, [r0, #CLKCTL_CDHIPR]
> @@ -321,10 +320,7 @@ setup_pll_func:
>  
>  	/* Switch peripheral to PLL2 */
>  	ldr r0, =CCM_BASE_ADDR
> -	ldr r1, =0x00808145
> -	orr r1, r1, #(2 << 10)
> -	orr r1, r1, #(0 << 16)
> -	orr r1, r1, #(1 << 19)
> +	ldr r1, =0x00888945
>  	str r1, [r0, #CLKCTL_CBCDR]
>  
>  	ldr r1, =0x00016154
> 

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2013-02-06  8:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-05 21:07 [U-Boot] [PATCH v3 1/4] nand: mxc: Prepare to add support for i.MX5 Benoît Thébaudeau
2013-02-05 21:07 ` [U-Boot] [PATCH v3 2/4] nand: mxc: Add " Benoît Thébaudeau
2013-02-05 21:07 ` [U-Boot] [PATCH v3 3/4] imx: mx5: lowlevel_init: Simplify code Benoît Thébaudeau
2013-02-06  8:56   ` Stefano Babic [this message]
2013-02-05 21:07 ` [U-Boot] [PATCH v3 4/4] imx: mx53ard: Add support for NAND Flash Benoît Thébaudeau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51121AB3.3000700@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.