From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx130.postini.com [74.125.245.130]) by kanga.kvack.org (Postfix) with SMTP id E8E9B6B0002 for ; Wed, 6 Feb 2013 05:10:54 -0500 (EST) Message-ID: <5112240C.1010105@cn.fujitsu.com> Date: Wed, 06 Feb 2013 17:36:12 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Julian Anastasov Cc: Andrew Morton , horms@verge.net.au, Linux MM , "linux-kernel@vger.kernel.org" , kamezawa.hiroyu@jp.fujitsu.com, minchan@kernel.org, mgorman@suse.de =E4=BA=8E 2013=E5=B9=B402=E6=9C=8806=E6=97=A5 17:29, Julian Anastasov =E5= =86=99=E9=81=93: >=20 > Hello, >=20 > Sorry that I'm writing a private email but I > deleted your original message by mistake. Your change > of the sysctl=5Fsync=5Fqlen=5Fmax from int to long is may be > not enough. >=20 > net/netfilter/ipvs/ip=5Fvs=5Fctl.c contains > proc var "sync=5Fqlen=5Fmax" that should be changed to > sizeof(unsigned long) and updated with proc=5Fdoulongvec=5Fminmax. >=20 Thanks for pointing this. I will update this in patch v2. Thanks Zhang Yanfei = -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757150Ab3BFKK6 (ORCPT ); Wed, 6 Feb 2013 05:10:58 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:15894 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754908Ab3BFKKz convert rfc822-to-8bit (ORCPT ); Wed, 6 Feb 2013 05:10:55 -0500 X-IronPort-AV: E=Sophos;i="4.84,614,1355068800"; d="scan'208";a="6696524" Message-ID: <5112240C.1010105@cn.fujitsu.com> Date: Wed, 06 Feb 2013 17:36:12 +0800 From: Zhang Yanfei User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.8) Gecko/20121012 Thunderbird/10.0.8 MIME-Version: 1.0 To: Julian Anastasov CC: Andrew Morton , horms@verge.net.au, Linux MM , "linux-kernel@vger.kernel.org" , kamezawa.hiroyu@jp.fujitsu.com, minchan@kernel.org, mgorman@suse.de Subject: Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max References: In-Reply-To: X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/02/06 17:36:28, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/02/06 17:36:52 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2013年02月06日 17:29, Julian Anastasov 写道: > > Hello, > > Sorry that I'm writing a private email but I > deleted your original message by mistake. Your change > of the sysctl_sync_qlen_max from int to long is may be > not enough. > > net/netfilter/ipvs/ip_vs_ctl.c contains > proc var "sync_qlen_max" that should be changed to > sizeof(unsigned long) and updated with proc_doulongvec_minmax. > Thanks for pointing this. I will update this in patch v2. Thanks Zhang Yanfei