From: Pontus Fuchs <pontus.fuchs@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] cfg80211: configuration for WoWLAN over TCP
Date: Wed, 06 Feb 2013 12:55:32 +0100 [thread overview]
Message-ID: <511244B4.2020007@gmail.com> (raw)
In-Reply-To: <1360075125.8376.11.camel@jlt4.sipsolutions.net>
On 2013-02-05 15:38, Johannes Berg wrote:
>>>> What's protecting this feature from stomping on an existing connection
>>>> when specifying the source port?
>>>
>>> Nothing. Presumably if you specify it you know what you're doing, and
>>> don't also create a connection to the same IP from the same port?
>>>
>>> Hmm. Maybe we could allocate the socket anyway and make it allocate the
>>> chosen port, failing if it isn't available? I guess I need to check the
>>> APIs.
>>
>> I guess this might work: http://p.sipsolutions.net/e5bc789d26b5e34a.txt
>
> Yep, seems to work, I'll fold that in. (Tested by having a TCP
> connection open and requesting the same port to be used)
Great! Patch looks good otherwise IMHO.
Cheers,
Pontus
prev parent reply other threads:[~2013-02-06 11:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 11:06 [RFC] cfg80211: configuration for WoWLAN over TCP Johannes Berg
2013-02-05 11:51 ` Johannes Berg
2013-02-05 13:47 ` Pontus Fuchs
2013-02-05 13:50 ` Johannes Berg
2013-02-05 14:17 ` Johannes Berg
2013-02-05 14:38 ` Johannes Berg
2013-02-06 11:55 ` Pontus Fuchs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511244B4.2020007@gmail.com \
--to=pontus.fuchs@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.