From: Chris Clayton <chris2553@googlemail.com>
To: Devin Heitmueller <dheitmueller@kernellabs.com>,
linux-media@vger.kernel.org
Subject: Re: WinTV-HVR-1400: scandvb (and kaffeine) fails to find any channels
Date: Wed, 06 Feb 2013 11:56:29 +0000 [thread overview]
Message-ID: <511244ED.5040607@googlemail.com> (raw)
In-Reply-To: <51111BC8.2010209@googlemail.com>
On 02/05/13 14:48, Chris Clayton wrote:
>
[snip]
>
> Well, after lots of hacking diagnostics into cx23885-i2c.c, I'm pretty
> sure that this is a timing problem. I've eventually found that if I
> insert a short delay into the top of i2c_sendbytes(), my HVR-1400
> expresscard dvb-t gadget starts to work. When I run a dvb scan, it finds
> all 117 services that are found using the same device on Windows 7 (and
> by a nearby Samsung TV). I have no idea why the delay makes the card work.
>
> A patch that makes this change is:
>
[snip]
OK, here's what I believe to be a better version of the patch:
--- linux-3.7.6/drivers/media/pci/cx23885/cx23885-i2c.c~
2013-02-01 19:46:56.000000000 +0000
+++ linux-3.7.6/drivers/media/pci/cx23885/cx23885-i2c.c 2013-02-06
11:08:31.000000000 +0000
@@ -92,6 +92,13 @@ static int i2c_sendbytes(struct i2c_adap
else
dprintk(1, "%s(msg->len=%d)\n", __func__, msg->len);
+ /* The XC3028L tuner on a WinTV-HVR-1400 fails to tune without
this */
+ if (dev->board == CX23885_BOARD_HAUPPAUGE_HVR1400) {
+ printk_once(KERN_INFO "%s - extra delay being applied for "
+ "HVR1400\n", i2c_adap->name);
+ udelay(8);
+ }
+
/* Deal with i2c probe functions with zero payload */
if (msg->len == 0) {
cx_write(bus->reg_addr, msg->addr << 25);
Signed-off-by: Chris Clayton <chris2553@googlemail.com>
It applies cleanly to 3.7.6 and to 3.80-rc6+ (pulled this morning).
Chris
prev parent reply other threads:[~2013-02-06 11:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 16:21 WinTV-HVR-1400: scandvb (and kaffeine) fails to find any channels Chris Clayton
2013-01-31 16:31 ` Devin Heitmueller
2013-01-31 20:59 ` Chris Clayton
2013-01-31 23:02 ` Chris Clayton
2013-02-01 11:53 ` Chris Clayton
[not found] ` <510BCE2F.1070100@googlemail.com>
2013-02-01 14:19 ` Devin Heitmueller
2013-02-01 21:03 ` Chris Clayton
2013-02-01 21:07 ` Devin Heitmueller
2013-02-03 0:03 ` Chris Clayton
2013-02-05 14:48 ` Chris Clayton
2013-02-06 11:56 ` Chris Clayton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511244ED.5040607@googlemail.com \
--to=chris2553@googlemail.com \
--cc=dheitmueller@kernellabs.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.