Re: [PATCH 4/4] MIPS: microMIPS: Add instruction utility macros.

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

On 06-02-2013 2:52, Steven J. Hill wrote:

> From: "Steven J. Hill" <sjhill@mips.com>

> Add two new macros for microMIPS. One checks if an exception was
> taken in either microMIPS or classic MIPS mode. The other checks
> if a microMIPS instruction is 16-bit or 32-bit in length.

> Signed-off-by: Steven J. Hill <sjhill@mips.com>
> ---
>   arch/mips/include/asm/mipsregs.h |   18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)

> diff --git a/arch/mips/include/asm/mipsregs.h b/arch/mips/include/asm/mipsregs.h
> index f206ef2..13e1d68 100644
> --- a/arch/mips/include/asm/mipsregs.h
> +++ b/arch/mips/include/asm/mipsregs.h
> @@ -622,6 +622,24 @@
>   #ifndef __ASSEMBLY__
>
>   /*
> + * Macros for handling the ISA mode bit for microMIPS.
> + */
> +#define get_isa16_mode(x)		((x) & 0x1)
> +#define msk_isa16_mode(x)		((x) & ~0x1)
> +#define set_isa16_mode(x)		do { (x) |= 0x1; } while(0)
> +
> +/*
> + * microMIPS instructions can be 16-bit or 32-bit in length. This
> + * returns a 1 if the instruction is 16-bit and a 0 if 32-bit.
> + */
> +static inline int mm_insn_16bit(u16 insn)
> +{
> +	u16 opcode = (insn >> 10) & 0x7;
> +
> +	return ((opcode >= 1 && opcode <= 3) ? 1 : 0);

    Parens are not really necessary there, are they?

WBR, Sergei