From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH 2/4] bgmac: write mac address to hardware in ndo_set_mac_address
Date: Wed, 06 Feb 2013 16:17:33 +0100 [thread overview]
Message-ID: <5112740D.2000402@hauke-m.de> (raw)
In-Reply-To: <CACna6rxjOU9URdV5C0M8fGcCh9sT-s2uoM9reUgigOTLz_qUYA@mail.gmail.com>
On 02/06/2013 03:57 PM, Rafał Miłecki wrote:
> 2013/2/6 Hauke Mehrtens <hauke@hauke-m.de>:
>> The generic implementation just changes the netdev struct and does not
>> write the new mac address to the hardware or issues some command to do
>> so.
>
> That's because generic "eth_mac_addr" allows changing MAC only when
> interface is down. And we "upload" MAC address during bringing
> interface up. So there wasn't any bug, it was just working that way :)
>
> One question: how you tested if changing MAC with keeping interface up
> works correctly? I just don't know if simple writes to
> BGMAC_MACADDR_HIGH and BGMAC_MACADDR_LOW are enough.
>
> If it works for you (changing MAC without stopping interface), I'm OK with that.
>
Yes that works in promisc and non promisc mode, I did this while pinging
the device and I had no package lose.
Hauke
next prev parent reply other threads:[~2013-02-06 15:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 14:44 [PATCH 0/4] bgmac: fixes and more netdev ops Hauke Mehrtens
2013-02-06 14:44 ` [PATCH 1/4] bgmac: implement missing code for BCM53572 Hauke Mehrtens
2013-02-06 14:54 ` Rafał Miłecki
2013-02-06 14:44 ` [PATCH 2/4] bgmac: write mac address to hardware in ndo_set_mac_address Hauke Mehrtens
2013-02-06 14:57 ` Rafał Miłecki
2013-02-06 15:17 ` Hauke Mehrtens [this message]
2013-02-06 14:44 ` [PATCH 3/4] bgmac: add generic ndo_validate_addr netdev ops Hauke Mehrtens
2013-02-06 14:45 ` [PATCH 4/4] bgmac: add ndo_set_rx_mode " Hauke Mehrtens
2013-02-06 14:58 ` Florian Fainelli
2013-02-06 15:51 ` [PATCH v2 " Hauke Mehrtens
2013-02-06 21:07 ` [PATCH 0/4] bgmac: fixes and more " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5112740D.2000402@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.