From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
To: Josh Durgin <josh.durgin@inktank.com>
Cc: ceph-devel@vger.kernel.org, Danny Al-Gaaf <dalgaaf@suse.de>,
Sage Weil <sage@inktank.com>
Subject: Re: [PATCH 2/3] .gitignore: cleanup and sort entries
Date: Wed, 06 Feb 2013 19:31:25 +0100 [thread overview]
Message-ID: <5112A17D.2080609@bisect.de> (raw)
In-Reply-To: <51121F03.8000005@inktank.com>
Thanks for the comments,
I will send an updated version of this patch with extra local handling
of Makefiles and where it makes sense also for some other files.
Danny
Am 06.02.2013 10:14, schrieb Josh Durgin:
> I like the cleanup in general, but non-generic entries should have
> a leading /, otherwise they match files with the same name in
> subdirectories as well.
>
> For example, putting Makefile in .gitignore will also ignore static
> makefiles in the qa subdirectories. Some of the existing entries are
> already missing this leading /.
>
> On 02/04/2013 09:22 AM, Danny Al-Gaaf wrote:
>> Cleanup old entries and sort the existing entries. Remove no longer
>> existing entries/files. Move src/* entries from top level .gitignore
>> to the correct subdir .gitignore file.
>>
>> Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
>> ---
>> .gitignore | 78 ++++++++++-------------
>> doc/.gitignore | 3 +-
>> src/.gitignore | 173
>> +++++++++++++--------------------------------------
>> src/.gitignore.orig | 142 ++++++++++++++++++++++++++++++++++++++++++
>
> No need for this file
>
>> src/gtest/.gitignore | 2 +
>> 5 files changed, 221 insertions(+), 177 deletions(-)
>> create mode 100644 src/.gitignore.orig
>> create mode 100644 src/gtest/.gitignore
>>
next prev parent reply other threads:[~2013-02-06 18:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 17:22 [PATCH 0/3] [RFC] rename files from ceph-test package Danny Al-Gaaf
2013-02-04 17:22 ` [PATCH 1/3] ceph-test: give binaries from ceph-test package useful names Danny Al-Gaaf
2013-02-06 9:05 ` Josh Durgin
2013-02-04 17:22 ` [PATCH 2/3] .gitignore: cleanup and sort entries Danny Al-Gaaf
2013-02-06 9:14 ` Josh Durgin
2013-02-06 18:31 ` Danny Al-Gaaf [this message]
2013-02-04 17:22 ` [PATCH 3/3] ceph-test.install: updated filelist Danny Al-Gaaf
2013-02-06 9:17 ` Josh Durgin
2013-02-06 8:30 ` [PATCH 0/3] [RFC] rename files from ceph-test package Danny Al-Gaaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5112A17D.2080609@bisect.de \
--to=danny.al-gaaf@bisect.de \
--cc=ceph-devel@vger.kernel.org \
--cc=dalgaaf@suse.de \
--cc=josh.durgin@inktank.com \
--cc=sage@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.