From: Wang Shilong <wangshilong1991@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH 1/3] Ext2: remove the overhead check about sb in the function ext2_new_blocks
Date: Wed, 06 Feb 2013 12:01:17 -0800 [thread overview]
Message-ID: <5112B68D.3080108@gmail.com> (raw)
From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
It can be guranteed that inode->i_sb should not be null in vfs.
So here the check about it is overhead.
Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
---
fs/ext2/balloc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
index 1c36139..22993a0 100644
--- a/fs/ext2/balloc.c
+++ b/fs/ext2/balloc.c
@@ -1239,10 +1239,6 @@ ext2_fsblk_t ext2_new_blocks(struct inode *inode, ext2_fsblk_t goal,
*errp = -ENOSPC;
sb = inode->i_sb;
- if (!sb) {
- printk("ext2_new_blocks: nonexistent device");
- return 0;
- }
/*
* Check quota for allocation of this block.
--
1.7.11.7
next reply other threads:[~2013-02-06 3:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 20:01 Wang Shilong [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-06 20:22 [PATCH 1/3] Ext2: remove the overhead check about sb in the function ext2_new_blocks Wang Shilong
2013-02-06 6:56 ` Zheng Liu
2013-02-06 18:29 ` Theodore Ts'o
2013-02-07 15:22 ` shilong wang
2013-02-08 4:54 ` Zheng Liu
2013-02-06 6:14 Wang shilong
2013-02-06 12:46 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5112B68D.3080108@gmail.com \
--to=wangshilong1991@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.