From: Rik van Riel <riel@redhat.com>
To: Michel Lespinasse <walken@google.com>
Cc: linux-kernel@vger.kernel.org, aquini@redhat.com,
eric.dumazet@gmail.com, lwoodman@redhat.com, knoel@redhat.com,
chegu_vinod@hp.com, raghavendra.kt@linux.vnet.ibm.com,
mingo@redhat.com
Subject: Re: [PATCH -v4 4/5] x86,smp: keep spinlock delay values per hashed spinlock address
Date: Wed, 06 Feb 2013 15:10:10 -0500 [thread overview]
Message-ID: <5112B8A2.8050800@redhat.com> (raw)
In-Reply-To: <CANN689EAykWXS4QTVDKaCb4in_2b_Bqyoh-xg=EbX7ivOPry4w@mail.gmail.com>
On 01/27/2013 08:04 AM, Michel Lespinasse wrote:
> On Fri, Jan 25, 2013 at 11:18 AM, Rik van Riel <riel@redhat.com> wrote:
>> + u32 delay = (ent->hash == hash) ? ent->delay : MIN_SPINLOCK_DELAY;
>
> I still don't like the reseting of delay to MIN_SPINLOCK_DELAY when
> there is a hash collision.
I've been spending some time looking at this, because I am
not a fan either.
However, it seems to work and I failed to come up with
anything better. Therefore, I have left it as is in the
-v5 patch series.
next prev parent reply other threads:[~2013-02-06 20:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 19:05 [PATCH -v4 0/5] x86,smp: make ticket spinlock proportional backoff w/ auto tuning Rik van Riel
2013-01-25 19:16 ` [PATCH -v4 1/5] x86,smp: move waiting on contended ticket lock out of line Rik van Riel
2013-01-25 19:17 ` [PATCH -v4 2/5] x86,smp: proportional backoff for ticket spinlocks Rik van Riel
2013-01-25 19:17 ` [PATCH -v4 3/5] x86,smp: auto tune spinlock backoff delay factor Rik van Riel
2013-01-26 12:03 ` Ingo Molnar
2013-01-25 19:18 ` [PATCH -v4 4/5] x86,smp: keep spinlock delay values per hashed spinlock address Rik van Riel
2013-01-27 13:04 ` Michel Lespinasse
2013-02-06 20:10 ` Rik van Riel [this message]
2013-02-09 23:50 ` Michel Lespinasse
2013-01-25 19:19 ` [PATCH -v4 5/5] x86,smp: limit spinlock delay on virtual machines Rik van Riel
2013-01-26 12:00 ` Ingo Molnar
2013-01-26 12:47 ` Borislav Petkov
2013-02-04 13:50 ` Rik van Riel
2013-02-04 14:02 ` Borislav Petkov
2013-02-06 17:05 ` Rik van Riel
2013-01-28 18:18 ` Stefano Stabellini
2013-01-28 18:18 ` Stefano Stabellini
2013-01-25 19:20 ` [DEBUG PATCH -v4 6/5] x86,smp: add debugging code to track spinlock delay value Rik van Riel
2013-01-26 7:21 ` [PATCH -v4 0/5] x86,smp: make ticket spinlock proportional backoff w/ auto tuning Mike Galbraith
2013-01-26 12:05 ` Ingo Molnar
2013-01-26 13:10 ` Mike Galbraith
2013-01-28 6:49 ` Raghavendra K T
2013-02-03 15:28 ` Chegu Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5112B8A2.8050800@redhat.com \
--to=riel@redhat.com \
--cc=aquini@redhat.com \
--cc=chegu_vinod@hp.com \
--cc=eric.dumazet@gmail.com \
--cc=knoel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lwoodman@redhat.com \
--cc=mingo@redhat.com \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.