From: Mark Tinguely <tinguely@sgi.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2 2/2] xfs: disable log force in xfs_buf_item_push() to avoid xa_lock recursion
Date: Wed, 06 Feb 2013 14:25:21 -0600 [thread overview]
Message-ID: <5112BC31.8040001@sgi.com> (raw)
In-Reply-To: <1360154681-28246-3-git-send-email-bfoster@redhat.com>
On 02/06/13 06:44, Brian Foster wrote:
> If the trylock fails and the buffer is pinned and stale, the
> resulting xfs_log_force() can lead to lock recursion on the ailp
> xa_lock. Call __xfs_buf_trylock() to attempt the buf lock with
> xa_lock held, but to avoid the log force. If the trylock had raced
> with the buffer being pinned, return XFS_ITEM_PINNED such that
> xfsaild will pend up a log force on the next scan.
>
> Signed-off-by: Brian Foster<bfoster@redhat.com>
> ---
> fs/xfs/xfs_buf_item.c | 14 +++++++++++++-
> 1 files changed, 13 insertions(+), 1 deletions(-)
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-02-06 20:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 12:44 [PATCH v2 0/2] fix spinlock recursion on xa_lock in xfs_buf_item_push Brian Foster
2013-02-06 12:44 ` [PATCH v2 1/2] xfs: conditionally force log on trylock failure of pinned/stale buf Brian Foster
2013-02-06 20:24 ` Mark Tinguely
2013-02-07 0:57 ` Dave Chinner
2013-02-06 12:44 ` [PATCH v2 2/2] xfs: disable log force in xfs_buf_item_push() to avoid xa_lock recursion Brian Foster
2013-02-06 20:25 ` Mark Tinguely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5112BC31.8040001@sgi.com \
--to=tinguely@sgi.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.