From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v7] cover: Coverage support Date: Thu, 7 Feb 2013 11:57:38 +0000 Message-ID: <511396B2.3030804@eu.citrix.com> References: <1360236482-25452-1-git-send-email-frediano.ziglio@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1360236482-25452-1-git-send-email-frediano.ziglio@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Frediano Ziglio Cc: Konrad Rzeszutek Wilk , "Keir (Xen.org)" , Ian Campbell , Jan Beulich , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 07/02/13 11:27, Frediano Ziglio wrote: > Updated set of patches for coverage. > > Changes: > - remove operation to check if coverage enabled > - add operation to read and reset coverage at same time > - updated utility to refrect changes above > I've done a once-over and in principle I think this is a good series. Thanks for doing it -- I think Xen has needed this for some time. Just a couple of high-level comments (and I haven't been following the discussion, so please forgive me if I'm contradicting something someone said somewhere else): First, re the name -- is there any reason not to call it "gcov" (or "xgcov" or something like that) in the patch series and the Xen command-line option? Since we're using the gcov format and the intent (I presume) is to use the gcov tools to do the actual analysis, Secondly, there doesn't seem to be any documentation. A definition of the Xen command-line term is an absolute minimum, and a brief markdown how-to explaining how to enable the option and use it would be much appreciated. -George