From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: [PATCH v3 02/23] n_tty: Factor packet mode status change for reuse Date: Thu, 07 Feb 2013 15:51:40 +0100 Message-ID: <5113BF7C.5060201@suse.cz> References: <1355509370-5883-1-git-send-email-peter@hurleysoftware.com> <1360095638-6624-1-git-send-email-peter@hurleysoftware.com> <1360095638-6624-3-git-send-email-peter@hurleysoftware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f173.google.com ([209.85.215.173]:62017 "EHLO mail-ea0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755589Ab3BGO6b (ORCPT ); Thu, 7 Feb 2013 09:58:31 -0500 In-Reply-To: <1360095638-6624-3-git-send-email-peter@hurleysoftware.com> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Peter Hurley Cc: Greg Kroah-Hartman , Alan Cox , Sasha Levin , Sebastian Andrzej Siewior , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Ilya Zykov , Dave Jones On 02/05/2013 09:20 PM, Peter Hurley wrote: > Factor the packet mode status change from n_tty_flush_buffer > for use by follow-on patch. > > Signed-off-by: Peter Hurley > --- > drivers/tty/n_tty.c | 24 ++++++++++++++---------- > 1 file changed, 14 insertions(+), 10 deletions(-) > > diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c > index bf6958b..7194a33 100644 > --- a/drivers/tty/n_tty.c > +++ b/drivers/tty/n_tty.c > @@ -237,6 +237,18 @@ static void reset_buffer_flags(struct tty_struct *tty) > n_tty_set_room(tty); > } > > +static void packet_mode_flush(struct tty_struct *tty) I prefer naming functions according the name space they live in. In this case n_tty_flush_packet_mode would be much better. Other than that this one looks good. -- js suse labs