All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Dongjiu Geng <gengdongjiu@huawei.com>
Cc: linux-kernel@vger.kernel.org, linuxarm@huawei.com
Subject: Re: Adjust interrupt Priority for ARM64 GIC
Date: Tue, 01 Sep 2020 08:48:02 +0100	[thread overview]
Message-ID: <51146530616bb8fdf23c637ff5bee44e@kernel.org> (raw)
In-Reply-To: <5a6e65cf-d2fe-0107-2318-0e3c81d57000@huawei.com>

Hi Dongjiu,

In the future, please use my kernel.org address, as I don't work
for ARM anymore, and would have missed this email if I wasn't pointed
to it.

On 2020-08-14 18:10, Dongjiu Geng wrote:
> Hi Marc,
>    In the Linux kernel, we can not adjust the  interrupt Priority, For
> all the interrupts, the interrupt Priority are fixed to 0xa0.
> In some scenarios, it needs to change the Priority. so I want to
> upstream a serie patch to support to change the Priority through
> procfs. do you agree I upstream this feature? thanks~

No, that's not something I would ever consider, and for multiple
reasons:

- Linux only supports a single priority, meaning that interrupts are
   themselves aren't preemptable. Dealing with things like (pseudo) NMI
   is invasive enough, and I can't see a good reason to relax the
   single priority requirement.

- Building on top of the above, the whole scheduler and locking model
   relies on the non-preemptable property of an interrupt.

- I cannot see a good reason to leave the priority control to userspace.
   That's a sure recipe for userspace-controlled livelocks.

Now, I'm sure you want to introduce this for a reason, and you are not
explaining it ("some scenarios" doesn't quite cut it). If you care to
explain these "scenarios", maybe there is something we can do.

But please don't waste time implementing any sort of priority change,
there is no way I'll consider it as such.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2020-09-01  7:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-14 17:10 Adjust interrupt Priority for ARM64 GIC Dongjiu Geng
2020-09-01  7:48 ` Marc Zyngier [this message]
2020-09-01  8:48   ` Dongjiu Geng
2020-09-01  9:06     ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51146530616bb8fdf23c637ff5bee44e@kernel.org \
    --to=maz@kernel.org \
    --cc=gengdongjiu@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.