From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v6 08/10] ARM: dt: Add references to tegra_car clocks Date: Fri, 08 Feb 2013 10:16:13 -0700 Message-ID: <511532DD.2080306@wwwdotorg.org> References: <1360330602-30472-1-git-send-email-pdeschrijver@nvidia.com> <1360330602-30472-9-git-send-email-pdeschrijver@nvidia.com> <20130208140301.GA23979@arwen.pp.htv.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130208140301.GA23979-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: balbi-l0cyMroinI0@public.gmane.org Cc: Peter De Schrijver , Russell King , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 02/08/2013 07:03 AM, Felipe Balbi wrote: > Hi, > > On Fri, Feb 08, 2013 at 03:36:40PM +0200, Peter De Schrijver > wrote: >> tegra_car: clock { - compatible = "nvidia,tegra114-car, >> nvidia,tegra30-car"; + compatible = "nvidia,tegra114-car"; > > trailing change or intentional ? I believe it's intentional since the HW isn't fully backwards-compatible. However, the commit description should mention this. From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Fri, 08 Feb 2013 10:16:13 -0700 Subject: [PATCH v6 08/10] ARM: dt: Add references to tegra_car clocks In-Reply-To: <20130208140301.GA23979@arwen.pp.htv.fi> References: <1360330602-30472-1-git-send-email-pdeschrijver@nvidia.com> <1360330602-30472-9-git-send-email-pdeschrijver@nvidia.com> <20130208140301.GA23979@arwen.pp.htv.fi> Message-ID: <511532DD.2080306@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/08/2013 07:03 AM, Felipe Balbi wrote: > Hi, > > On Fri, Feb 08, 2013 at 03:36:40PM +0200, Peter De Schrijver > wrote: >> tegra_car: clock { - compatible = "nvidia,tegra114-car, >> nvidia,tegra30-car"; + compatible = "nvidia,tegra114-car"; > > trailing change or intentional ? I believe it's intentional since the HW isn't fully backwards-compatible. However, the commit description should mention this. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946776Ab3BHRQS (ORCPT ); Fri, 8 Feb 2013 12:16:18 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:51986 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946674Ab3BHRQQ (ORCPT ); Fri, 8 Feb 2013 12:16:16 -0500 Message-ID: <511532DD.2080306@wwwdotorg.org> Date: Fri, 08 Feb 2013 10:16:13 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: balbi@ti.com CC: Peter De Schrijver , Russell King , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 08/10] ARM: dt: Add references to tegra_car clocks References: <1360330602-30472-1-git-send-email-pdeschrijver@nvidia.com> <1360330602-30472-9-git-send-email-pdeschrijver@nvidia.com> <20130208140301.GA23979@arwen.pp.htv.fi> In-Reply-To: <20130208140301.GA23979@arwen.pp.htv.fi> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/2013 07:03 AM, Felipe Balbi wrote: > Hi, > > On Fri, Feb 08, 2013 at 03:36:40PM +0200, Peter De Schrijver > wrote: >> tegra_car: clock { - compatible = "nvidia,tegra114-car, >> nvidia,tegra30-car"; + compatible = "nvidia,tegra114-car"; > > trailing change or intentional ? I believe it's intentional since the HW isn't fully backwards-compatible. However, the commit description should mention this.