From: Chris Boot <bootc@bootc.net>
To: Roland Dreier <roland@kernel.org>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
Roland Dreier <roland@purestorage.com>
Subject: Re: [PATCH 2/3] target: Fix error checking for UNMAP commands
Date: Sat, 09 Feb 2013 09:23:31 +0000 [thread overview]
Message-ID: <51161593.9030007@bootc.net> (raw)
In-Reply-To: <1360365520-11972-2-git-send-email-roland@kernel.org>
On 08/02/2013 23:18, Roland Dreier wrote:
> diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
> index b526d23..b72ca5b 100644
> --- a/drivers/target/target_core_iblock.c
> +++ b/drivers/target/target_core_iblock.c
> @@ -2674,6 +2675,15 @@ transport_send_check_condition_and_sense(struct se_cmd *cmd,
> /* INVALID FIELD IN PARAMETER LIST */
> buffer[SPC_ASC_KEY_OFFSET] = 0x26;
> break;
> + case TCM_PARAMETER_LIST_LENGTH_ERROR:
> + /* CURRENT ERROR */
> + buffer[0] = 0x70;
> + buffer[SPC_ADD_SENSE_LEN_OFFSET] = 10;
> + /* ILLEGAL REQUEST */
> + buffer[SPC_SENSE_KEY_OFFSET] = ILLEGAL_REQUEST;
> + /* INVALID FIELD IN PARAMETER LIST */
> + buffer[SPC_ASC_KEY_OFFSET] = 0x1a;
> + break;
> case TCM_UNEXPECTED_UNSOLICITED_DATA:
> /* CURRENT ERROR */
> buffer[0] = 0x70;
Nitpick: I suspect a simple copy & paste error; "INVALID FIELD IN
PARAMETER LIST" in your comment should probably read "PARAMETER LIST
LENGTH ERROR" instead.
HTH,
Chris
--
Chris Boot
bootc@bootc.net
next prev parent reply other threads:[~2013-02-09 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 23:18 [PATCH 1/3] target: Fix sense data for out-of-bounds IO operations Roland Dreier
2013-02-08 23:18 ` [PATCH 2/3] target: Fix error checking for UNMAP commands Roland Dreier
2013-02-09 9:23 ` Chris Boot [this message]
2013-02-09 19:27 ` Roland Dreier
2013-02-13 20:27 ` Nicholas A. Bellinger
2013-02-08 23:18 ` [PATCH 3/3] target: Fix parameter list length checking in MODE SELECT Roland Dreier
2013-02-13 20:27 ` Nicholas A. Bellinger
2013-02-13 20:26 ` [PATCH 1/3] target: Fix sense data for out-of-bounds IO operations Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51161593.9030007@bootc.net \
--to=bootc@bootc.net \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=roland@kernel.org \
--cc=roland@purestorage.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.