From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
Benoit Thebaudeau <benoit.thebaudeau@advansee.com>,
David Hardeman <david@hardeman.nu>,
Trilok Soni <tsoni@codeaurora.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Matus Ujhelyi <ujhelyi.m@gmail.com>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v2] media: rc: gpio-ir-recv: add support for device tree parsing
Date: Sat, 09 Feb 2013 18:05:58 +0100 [thread overview]
Message-ID: <511681F6.4010102@gmail.com> (raw)
In-Reply-To: <51159C36.1060602@gmail.com>
On 02/09/2013 01:45 AM, Sebastian Hesselbarth wrote:
>>> new file mode 100644
>>> index 0000000..8589f30
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/media/gpio-ir-receiver.txt
>>> @@ -0,0 +1,16 @@
>>> +Device-Tree bindings for GPIO IR receiver
>>> +
>>> +Required properties:
>>> + - compatible = "gpio-ir-receiver";
>>> + - gpios: OF device-tree gpio specification.
>>> +
>>> +Optional properties:
>>> + - linux,rc-map-name: Linux specific remote control map name.
>>> +
>>> +Example node:
>>> +
>>> + ir: ir-receiver {
>>> + compatible = "gpio-ir-receiver";
>>> + gpios =<&gpio0 19 1>;
>>> + linux,rc-map-name = "rc-rc6-mce";
>>
>> Please change this to:
>> linux,rc-map-name = RC_MAP_RC6_MCE;
>>
>> (as defined at include/media/rc-map.h).
>
> Mauro,
>
> this is not possible in device tree bindings. Device tree properties
> can only carry numeric or string types (and some other stuff) but no
> OS specific enumerations. So using strings is the only option here.
>
>> The idea of having those strings defined at the same header file is to:
>
> Unfortunately, device tree blobs don't know about linux header files.
I suppose this will change when it will be possible to run C pre-processor
on *.dts files. This is still under discussion though [1] and for the
device tree there will likely be separate copies of the header files
needed. Thus I guess explicit string names for now need to be used.
[1] http://www.spinics.net/lists/kernel/msg1458360.html
prev parent reply other threads:[~2013-02-09 17:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 19:07 [PATCH] media: rc: gpio-ir-recv: add support for device tree parsing Sebastian Hesselbarth
2013-02-06 8:03 ` [PATCH RESEND] " Sebastian Hesselbarth
2013-02-06 13:48 ` Sylwester Nawrocki
2013-02-06 17:18 ` Sebastian Hesselbarth
2013-02-08 17:57 ` Mauro Carvalho Chehab
2013-02-08 18:12 ` Sebastian Hesselbarth
2013-02-08 19:06 ` Mauro Carvalho Chehab
2013-02-08 19:03 ` Sylwester Nawrocki
2013-02-08 20:38 ` [PATCH v2] " Sebastian Hesselbarth
2013-02-08 21:26 ` Sylwester Nawrocki
2013-02-08 21:36 ` Sebastian Hesselbarth
2013-02-08 21:52 ` Sylwester Nawrocki
2013-02-08 22:47 ` [PATCH v3] " Sebastian Hesselbarth
2013-02-09 0:03 ` [PATCH v2] " Mauro Carvalho Chehab
2013-02-09 0:45 ` Sebastian Hesselbarth
2013-02-09 13:41 ` Mauro Carvalho Chehab
2013-02-09 17:05 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511681F6.4010102@gmail.com \
--to=sylvester.nawrocki@gmail.com \
--cc=benoit.thebaudeau@advansee.com \
--cc=david@hardeman.nu \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=s.nawrocki@samsung.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tsoni@codeaurora.org \
--cc=ujhelyi.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.