From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
To: Sage Weil <sage@inktank.com>
Cc: ceph-devel@vger.kernel.org, Danny Al-Gaaf <dalgaaf@suse.de>
Subject: Re: [PATCH 5/6] SyntheticClient.cc: fix some memory leaks in the error handling
Date: Sun, 10 Feb 2013 09:43:47 +0100 [thread overview]
Message-ID: <51175DC3.2020008@bisect.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1302092203440.11665@cobra.newdream.net>
Am 10.02.2013 07:04, schrieb Sage Weil:
> On Fri, 8 Feb 2013, Danny Al-Gaaf wrote:
[...]
>> //dout(5) << "SyntheticClient::write_fd: writing to fd " << fd << dendl;
>> - if (fd < 0) return fd;
>> + if (fd < 0) {
>> + return fd;
>> + delete[] buf;
>
> oops, wrong order...
I know, that's why I've send another fixed version of this patch to the
list the same day:
http://thread.gmane.org/gmane.comp.file-systems.ceph.devel/12969/focus=12985
Danny
next prev parent reply other threads:[~2013-02-10 8:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 16:24 [PATCH 0/6] Fix some memory leaks in Ceph Danny Al-Gaaf
2013-02-08 16:24 ` [PATCH 1/6] common/fiemap.cc: fix realloc memory leak Danny Al-Gaaf
2013-02-08 16:24 ` [PATCH 2/6] os/FileStore.cc: fix realloc memory leak in error case Danny Al-Gaaf
2013-02-08 16:25 ` [PATCH 3/6] rgw/rgw_xml.cc: " Danny Al-Gaaf
2013-02-08 16:25 ` [PATCH 4/6] wireshark: fix some memory leaks Danny Al-Gaaf
2013-02-08 16:25 ` [PATCH 5/6] SyntheticClient.cc: fix some memory leaks in the error handling Danny Al-Gaaf
2013-02-08 17:47 ` Danny Al-Gaaf
2013-02-08 17:52 ` [PATCH v2 " Danny Al-Gaaf
2013-02-10 6:04 ` [PATCH " Sage Weil
2013-02-10 8:43 ` Danny Al-Gaaf [this message]
2013-02-11 2:07 ` Sage Weil
2013-02-08 16:25 ` [PATCH 6/6] rgw/rgw_rest.cc: fix 4K memory leak Danny Al-Gaaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51175DC3.2020008@bisect.de \
--to=danny.al-gaaf@bisect.de \
--cc=ceph-devel@vger.kernel.org \
--cc=dalgaaf@suse.de \
--cc=sage@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.