From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pankaj Gupta Subject: Re: [PATCH v4 5/5] xfs: disable map_sync for async flush Date: Thu, 4 Apr 2019 06:52:16 -0400 (EDT) Message-ID: <511760533.17430856.1554375136102.JavaMail.zimbra@redhat.com> References: <20190403104018.23947-1-pagupta@redhat.com> <20190403104018.23947-6-pagupta@redhat.com> <20190403220912.GB26298@dastard> <1518295599.17367903.1554358350929.JavaMail.zimbra@redhat.com> <20190404095649.GB8738@angband.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20190404095649.GB8738@angband.pl> Sender: linux-kernel-owner@vger.kernel.org To: Adam Borowski Cc: Dave Chinner , darrick wong , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org, qemu-devel@nongnu.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, dan j williams , zwisler@kernel.org, vishal l verma , dave jiang , mst@redhat.com, jasowang@redhat.com, willy@infradead.org, rjw@rjwysocki.net, hch@infradead.org, lenb@kernel.org, jack@suse.cz, tytso@mit.edu, adilger kernel , lcapitulino@redhat.com, kwolf@redhat.com, imammedo@redhat.com, jmoyer@redhat.com, nilal@redhat.com, riel@surriel.com List-Id: linux-acpi@vger.kernel.org > > On Thu, Apr 04, 2019 at 02:12:30AM -0400, Pankaj Gupta wrote: > > > All this ad hoc IS_DAX conditional logic is getting pretty nasty. > > > > > > xfs_file_mmap( > > > .... > > > { > > > struct inode *inode = file_inode(filp); > > > > > > if (vma->vm_flags & VM_SYNC) { > > > if (!IS_DAX(inode)) > > > return -EOPNOTSUPP; > > > if (!dax_synchronous(xfs_find_daxdev_for_inode(inode)) > > > return -EOPNOTSUPP; > > > } > > > > > > file_accessed(filp); > > > vma->vm_ops = &xfs_file_vm_ops; > > > if (IS_DAX(inode)) > > > vma->vm_flags |= VM_HUGEPAGE; > > > return 0; > > > } > > > > Sure, this is better. > > > > Even better, factor out all the "MAP_SYNC supported" checks into a > > > helper so that the filesystem code just doesn't have to care about > > > the details of checking for DAX+MAP_SYNC support.... > > > > o.k. Will add one common helper function for both ext4 & xfs filesystems. > > Note this pending patch for Goldwyn Rodrigues' patchset for btrfs: > > https://lore.kernel.org/linux-btrfs/20190328102418.5466-1-kilobyte@angband.pl/ > > We might want to coordinate. Sure. Good to know. Thanks for the pointer. Will have a look. Best regards, Pankaj > > > Meow! > -- > ⢀⣴⠾⠻⢶⣦⠀ > ⣾⠁⢠⠒⠀⣿⡁ Did ya know that typing "test -j8" instead of "ctest -j8" > ⢿⡄⠘⠷⠚⠋⠀ will make your testsuite pass much faster, and fix bugs? > ⠈⠳⣄⠀⠀⠀⠀ > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D970C4360F for ; Thu, 4 Apr 2019 10:52:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA96B20820 for ; Thu, 4 Apr 2019 10:52:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729531AbfDDKwS convert rfc822-to-8bit (ORCPT ); Thu, 4 Apr 2019 06:52:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51552 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726694AbfDDKwS (ORCPT ); Thu, 4 Apr 2019 06:52:18 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 584D5C05D3F9; Thu, 4 Apr 2019 10:52:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E052B9880; Thu, 4 Apr 2019 10:52:16 +0000 (UTC) Received: from zmail21.collab.prod.int.phx2.redhat.com (zmail21.collab.prod.int.phx2.redhat.com [10.5.83.24]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 72F813FB10; Thu, 4 Apr 2019 10:52:16 +0000 (UTC) Date: Thu, 4 Apr 2019 06:52:16 -0400 (EDT) From: Pankaj Gupta To: Adam Borowski Cc: Dave Chinner , darrick wong , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org, qemu-devel@nongnu.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, dan j williams , zwisler@kernel.org, vishal l verma , dave jiang , mst@redhat.com, jasowang@redhat.com, willy@infradead.org, rjw@rjwysocki.net, hch@infradead.org, lenb@kernel.org, jack@suse.cz, tytso@mit.edu, adilger kernel , lcapitulino@redhat.com, kwolf@redhat.com, imammedo@redhat.com, jmoyer@redhat.com, nilal@redhat.com, riel@surriel.com, stefanha@redhat.com, aarcange@redhat.com, david@redhat.com, cohuck@redhat.com, xiaoguangrong eric Message-ID: <511760533.17430856.1554375136102.JavaMail.zimbra@redhat.com> In-Reply-To: <20190404095649.GB8738@angband.pl> References: <20190403104018.23947-1-pagupta@redhat.com> <20190403104018.23947-6-pagupta@redhat.com> <20190403220912.GB26298@dastard> <1518295599.17367903.1554358350929.JavaMail.zimbra@redhat.com> <20190404095649.GB8738@angband.pl> Subject: Re: [PATCH v4 5/5] xfs: disable map_sync for async flush MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.67.116.146, 10.4.195.15] Thread-Topic: disable map_sync for async flush Thread-Index: GSPGZe3LJnzVq67kTWZ5Pd+VWv3BqA== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 04 Apr 2019 10:52:17 +0000 (UTC) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org > > On Thu, Apr 04, 2019 at 02:12:30AM -0400, Pankaj Gupta wrote: > > > All this ad hoc IS_DAX conditional logic is getting pretty nasty. > > > > > > xfs_file_mmap( > > > .... > > > { > > > struct inode *inode = file_inode(filp); > > > > > > if (vma->vm_flags & VM_SYNC) { > > > if (!IS_DAX(inode)) > > > return -EOPNOTSUPP; > > > if (!dax_synchronous(xfs_find_daxdev_for_inode(inode)) > > > return -EOPNOTSUPP; > > > } > > > > > > file_accessed(filp); > > > vma->vm_ops = &xfs_file_vm_ops; > > > if (IS_DAX(inode)) > > > vma->vm_flags |= VM_HUGEPAGE; > > > return 0; > > > } > > > > Sure, this is better. > > > > Even better, factor out all the "MAP_SYNC supported" checks into a > > > helper so that the filesystem code just doesn't have to care about > > > the details of checking for DAX+MAP_SYNC support.... > > > > o.k. Will add one common helper function for both ext4 & xfs filesystems. > > Note this pending patch for Goldwyn Rodrigues' patchset for btrfs: > > https://lore.kernel.org/linux-btrfs/20190328102418.5466-1-kilobyte@angband.pl/ > > We might want to coordinate. Sure. Good to know. Thanks for the pointer. Will have a look. Best regards, Pankaj > > > Meow! > -- > ⢀⣴⠾⠻⢶⣦⠀ > ⣾⠁⢠⠒⠀⣿⡁ Did ya know that typing "test -j8" instead of "ctest -j8" > ⢿⡄⠘⠷⠚⠋⠀ will make your testsuite pass much faster, and fix bugs? > ⠈⠳⣄⠀⠀⠀⠀ > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0FAA5211F932B for ; Thu, 4 Apr 2019 03:52:18 -0700 (PDT) Date: Thu, 4 Apr 2019 06:52:16 -0400 (EDT) From: Pankaj Gupta Message-ID: <511760533.17430856.1554375136102.JavaMail.zimbra@redhat.com> In-Reply-To: <20190404095649.GB8738@angband.pl> References: <20190403104018.23947-1-pagupta@redhat.com> <20190403104018.23947-6-pagupta@redhat.com> <20190403220912.GB26298@dastard> <1518295599.17367903.1554358350929.JavaMail.zimbra@redhat.com> <20190404095649.GB8738@angband.pl> Subject: Re: [PATCH v4 5/5] xfs: disable map_sync for async flush MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Adam Borowski Cc: cohuck@redhat.com, jack@suse.cz, kvm@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, Dave Chinner , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, adilger kernel , zwisler@kernel.org, aarcange@redhat.com, linux-nvdimm@lists.01.org, david@redhat.com, willy@infradead.org, hch@infradead.org, linux-acpi@vger.kernel.org, linux-ext4@vger.kernel.org, lenb@kernel.org, riel@surriel.com, stefanha@redhat.com, lcapitulino@redhat.com, kwolf@redhat.com, nilal@redhat.com, tytso@mit.edu, xiaoguangrong eric , darrick wong , rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, imammedo@redhat.com List-ID: Cj4gCj4gT24gVGh1LCBBcHIgMDQsIDIwMTkgYXQgMDI6MTI6MzBBTSAtMDQwMCwgUGFua2FqIEd1 cHRhIHdyb3RlOgo+ID4gPiBBbGwgdGhpcyBhZCBob2MgSVNfREFYIGNvbmRpdGlvbmFsIGxvZ2lj IGlzIGdldHRpbmcgcHJldHR5IG5hc3R5Lgo+ID4gPiAKPiA+ID4geGZzX2ZpbGVfbW1hcCgKPiA+ ID4gLi4uLgo+ID4gPiB7Cj4gPiA+IAlzdHJ1Y3QgaW5vZGUJKmlub2RlID0gZmlsZV9pbm9kZShm aWxwKTsKPiA+ID4gCj4gPiA+IAlpZiAodm1hLT52bV9mbGFncyAmIFZNX1NZTkMpIHsKPiA+ID4g CQlpZiAoIUlTX0RBWChpbm9kZSkpCj4gPiA+IAkJCXJldHVybiAtRU9QTk9UU1VQUDsKPiA+ID4g CQlpZiAoIWRheF9zeW5jaHJvbm91cyh4ZnNfZmluZF9kYXhkZXZfZm9yX2lub2RlKGlub2RlKSkK PiA+ID4gCQkJcmV0dXJuIC1FT1BOT1RTVVBQOwo+ID4gPiAJfQo+ID4gPiAKPiA+ID4gCWZpbGVf YWNjZXNzZWQoZmlscCk7Cj4gPiA+IAl2bWEtPnZtX29wcyA9ICZ4ZnNfZmlsZV92bV9vcHM7Cj4g PiA+IAlpZiAoSVNfREFYKGlub2RlKSkKPiA+ID4gCQl2bWEtPnZtX2ZsYWdzIHw9IFZNX0hVR0VQ QUdFOwo+ID4gPiAJcmV0dXJuIDA7Cj4gPiA+IH0KPiA+IAo+ID4gU3VyZSwgdGhpcyBpcyBiZXR0 ZXIuCj4gCj4gPiA+IEV2ZW4gYmV0dGVyLCBmYWN0b3Igb3V0IGFsbCB0aGUgIk1BUF9TWU5DIHN1 cHBvcnRlZCIgY2hlY2tzIGludG8gYQo+ID4gPiBoZWxwZXIgc28gdGhhdCB0aGUgZmlsZXN5c3Rl bSBjb2RlIGp1c3QgZG9lc24ndCBoYXZlIHRvIGNhcmUgYWJvdXQKPiA+ID4gdGhlIGRldGFpbHMg b2YgY2hlY2tpbmcgZm9yIERBWCtNQVBfU1lOQyBzdXBwb3J0Li4uLgo+ID4gCj4gPiBvLmsuIFdp bGwgYWRkIG9uZSBjb21tb24gaGVscGVyIGZ1bmN0aW9uIGZvciBib3RoIGV4dDQgJiB4ZnMgZmls ZXN5c3RlbXMuCj4gCj4gTm90ZSB0aGlzIHBlbmRpbmcgcGF0Y2ggZm9yIEdvbGR3eW4gUm9kcmln dWVzJyBwYXRjaHNldCBmb3IgYnRyZnM6Cj4gCj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGlu dXgtYnRyZnMvMjAxOTAzMjgxMDI0MTguNTQ2Ni0xLWtpbG9ieXRlQGFuZ2JhbmQucGwvCj4gCj4g V2UgbWlnaHQgd2FudCB0byBjb29yZGluYXRlLgoKU3VyZS4gR29vZCB0byBrbm93LgoKVGhhbmtz IGZvciB0aGUgcG9pbnRlci4gV2lsbCBoYXZlIGEgbG9vay4KCkJlc3QgcmVnYXJkcywKUGFua2Fq IAoKPiAKPiAKPiBNZW93IQo+IC0tCj4g4qKA4qO04qC+4qC74qK24qOm4qCACj4g4qO+4qCB4qKg 4qCS4qCA4qO/4qGBIERpZCB5YSBrbm93IHRoYXQgdHlwaW5nICJ0ZXN0IC1qOCIgaW5zdGVhZCBv ZiAiY3Rlc3QgLWo4Igo+IOKiv+KhhOKgmOKgt+KgmuKgi+KggCB3aWxsIG1ha2UgeW91ciB0ZXN0 c3VpdGUgcGFzcyBtdWNoIGZhc3RlciwgYW5kIGZpeCBidWdzPwo+IOKgiOKgs+KjhOKggOKggOKg gOKggAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpM aW51eC1udmRpbW0gbWFpbGluZyBsaXN0CkxpbnV4LW52ZGltbUBsaXN0cy4wMS5vcmcKaHR0cHM6 Ly9saXN0cy4wMS5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1udmRpbW0K From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pankaj Gupta Subject: Re: [PATCH v4 5/5] xfs: disable map_sync for async flush Date: Thu, 4 Apr 2019 06:52:16 -0400 (EDT) Message-ID: <511760533.17430856.1554375136102.JavaMail.zimbra@redhat.com> References: <20190403104018.23947-1-pagupta@redhat.com> <20190403104018.23947-6-pagupta@redhat.com> <20190403220912.GB26298@dastard> <1518295599.17367903.1554358350929.JavaMail.zimbra@redhat.com> <20190404095649.GB8738@angband.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Cc: Dave Chinner , darrick wong , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org, qemu-devel@nongnu.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, dan j williams , zwisler@kernel.org, vishal l verma , dave jiang , mst@redhat.com, jasowang@redhat.com, willy@infradead.org, rjw@rjwysocki.net, hch@infradead.org, lenb@kernel.org, jack@suse.cz, tytso@mit.edu, adilger kernel , lcapitulino@redhat.com, kwolf@redhat.com, imammedo@redhat.com, jmoyer@redhat.com, nilal@redhat.com, riel@surriel.com, To: Adam Borowski Return-path: In-Reply-To: <20190404095649.GB8738@angband.pl> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org > > On Thu, Apr 04, 2019 at 02:12:30AM -0400, Pankaj Gupta wrote: > > > All this ad hoc IS_DAX conditional logic is getting pretty nasty. > > > > > > xfs_file_mmap( > > > .... > > > { > > > struct inode *inode = file_inode(filp); > > > > > > if (vma->vm_flags & VM_SYNC) { > > > if (!IS_DAX(inode)) > > > return -EOPNOTSUPP; > > > if (!dax_synchronous(xfs_find_daxdev_for_inode(inode)) > > > return -EOPNOTSUPP; > > > } > > > > > > file_accessed(filp); > > > vma->vm_ops = &xfs_file_vm_ops; > > > if (IS_DAX(inode)) > > > vma->vm_flags |= VM_HUGEPAGE; > > > return 0; > > > } > > > > Sure, this is better. > > > > Even better, factor out all the "MAP_SYNC supported" checks into a > > > helper so that the filesystem code just doesn't have to care about > > > the details of checking for DAX+MAP_SYNC support.... > > > > o.k. Will add one common helper function for both ext4 & xfs filesystems. > > Note this pending patch for Goldwyn Rodrigues' patchset for btrfs: > > https://lore.kernel.org/linux-btrfs/20190328102418.5466-1-kilobyte@angband.pl/ > > We might want to coordinate. Sure. Good to know. Thanks for the pointer. Will have a look. Best regards, Pankaj > > > Meow! > -- > ⢀⣴⠾⠻⢶⣦⠀ > ⣾⠁⢠⠒⠀⣿⡁ Did ya know that typing "test -j8" instead of "ctest -j8" > ⢿⡄⠘⠷⠚⠋⠀ will make your testsuite pass much faster, and fix bugs? > ⠈⠳⣄⠀⠀⠀⠀ > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:60753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hC014-00044p-9r for qemu-devel@nongnu.org; Thu, 04 Apr 2019 06:54:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBzyn-0004f7-0g for qemu-devel@nongnu.org; Thu, 04 Apr 2019 06:52:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43932) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hBzym-0004WK-L6 for qemu-devel@nongnu.org; Thu, 04 Apr 2019 06:52:20 -0400 Date: Thu, 4 Apr 2019 06:52:16 -0400 (EDT) From: Pankaj Gupta Message-ID: <511760533.17430856.1554375136102.JavaMail.zimbra@redhat.com> In-Reply-To: <20190404095649.GB8738@angband.pl> References: <20190403104018.23947-1-pagupta@redhat.com> <20190403104018.23947-6-pagupta@redhat.com> <20190403220912.GB26298@dastard> <1518295599.17367903.1554358350929.JavaMail.zimbra@redhat.com> <20190404095649.GB8738@angband.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 5/5] xfs: disable map_sync for async flush List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Adam Borowski Cc: Dave Chinner , darrick wong , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org, qemu-devel@nongnu.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, dan j williams , zwisler@kernel.org, vishal l verma , dave jiang , mst@redhat.com, jasowang@redhat.com, willy@infradead.org, rjw@rjwysocki.net, hch@infradead.org, lenb@kernel.org, jack@suse.cz, tytso@mit.edu, adilger kernel , lcapitulino@redhat.com, kwolf@redhat.com, imammedo@redhat.com, jmoyer@redhat.com, nilal@redhat.com, riel@surriel.com, stefanha@redhat.com, aarcange@redhat.com, david@redhat.com, cohuck@redhat.com, xiaoguangrong eric >=20 > On Thu, Apr 04, 2019 at 02:12:30AM -0400, Pankaj Gupta wrote: > > > All this ad hoc IS_DAX conditional logic is getting pretty nasty. > > >=20 > > > xfs_file_mmap( > > > .... > > > { > > > =09struct inode=09*inode =3D file_inode(filp); > > >=20 > > > =09if (vma->vm_flags & VM_SYNC) { > > > =09=09if (!IS_DAX(inode)) > > > =09=09=09return -EOPNOTSUPP; > > > =09=09if (!dax_synchronous(xfs_find_daxdev_for_inode(inode)) > > > =09=09=09return -EOPNOTSUPP; > > > =09} > > >=20 > > > =09file_accessed(filp); > > > =09vma->vm_ops =3D &xfs_file_vm_ops; > > > =09if (IS_DAX(inode)) > > > =09=09vma->vm_flags |=3D VM_HUGEPAGE; > > > =09return 0; > > > } > >=20 > > Sure, this is better. >=20 > > > Even better, factor out all the "MAP_SYNC supported" checks into a > > > helper so that the filesystem code just doesn't have to care about > > > the details of checking for DAX+MAP_SYNC support.... > >=20 > > o.k. Will add one common helper function for both ext4 & xfs filesystem= s. >=20 > Note this pending patch for Goldwyn Rodrigues' patchset for btrfs: >=20 > https://lore.kernel.org/linux-btrfs/20190328102418.5466-1-kilobyte@angban= d.pl/ >=20 > We might want to coordinate. Sure. Good to know. Thanks for the pointer. Will have a look. Best regards, Pankaj=20 >=20 >=20 > Meow! > -- > =E2=A2=80=E2=A3=B4=E2=A0=BE=E2=A0=BB=E2=A2=B6=E2=A3=A6=E2=A0=80 > =E2=A3=BE=E2=A0=81=E2=A2=A0=E2=A0=92=E2=A0=80=E2=A3=BF=E2=A1=81 Did ya kn= ow that typing "test -j8" instead of "ctest -j8" > =E2=A2=BF=E2=A1=84=E2=A0=98=E2=A0=B7=E2=A0=9A=E2=A0=8B=E2=A0=80 will make= your testsuite pass much faster, and fix bugs? > =E2=A0=88=E2=A0=B3=E2=A3=84=E2=A0=80=E2=A0=80=E2=A0=80=E2=A0=80 >=20