All of lore.kernel.org
 help / color / mirror / Atom feed
From: Floris Bos <bos@je-eigen-domein.nl>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/rpi-userland: update to fix no-longer applying patch
Date: Sun, 10 Feb 2013 16:28:07 +0100	[thread overview]
Message-ID: <5117BC87.5060804@je-eigen-domein.nl> (raw)
In-Reply-To: <CAHXCMML7-7p5+iTCAn_9OPZfYp141re-Hx21JLCizNzsdER1dg@mail.gmail.com>

On 02/10/2013 04:10 PM, Samuel Martin wrote:
> Documentation is incorrect/outdated.
>
> Github only looks at the folder name, ignores the filename, and will
> redirect you to
> https://nodeload.github.com/raspberrypi/userland/legacy.tar.gz/master
>
> [...]
>> With
>> "RPI_USERLAND_SITE=http://github.com/raspberrypi/userland/tarball/$(RPI_USERLAND_VERSION)"
>> it does work:
> [...]
>
> Fair enough.
> Care to fix/update the doc?
>
> Also, rpi-userland is not the only package fetched from github...
> So patches for all other potentially broken packages will be welcome as well.

Problem is that if they were to change their tarball URLs in the future, 
it would break all github packages again.
Wonder if it wouldn't be a better long term solution to have some kind 
of abstraction for github (and perhaps sourceforge) packages.

E.g. specify "FOO_SITE=github://foopackage" in the package's makefile, 
and add a special DOWNLOAD_GITHUB helper routine in pkg-download.mk
So we would only need to update pkg-download.mk if it were to change again.


Yours sincerely,

Floris Bos

      parent reply	other threads:[~2013-02-10 15:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-10 11:58 [Buildroot] [PATCH] package/rpi-userland: update to fix no-longer applying patch Yann E. MORIN
2013-02-10 12:17 ` Maxime Hadjinlian
2013-02-10 12:59 ` Peter Korsgaard
2013-02-10 13:24 ` Floris Bos
2013-02-10 14:14   ` Maxime Hadjinlian
2013-02-10 14:51     ` Floris Bos
2013-02-10 15:10       ` Samuel Martin
2013-02-10 15:13         ` Maxime Hadjinlian
2013-02-10 15:28         ` Floris Bos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5117BC87.5060804@je-eigen-domein.nl \
    --to=bos@je-eigen-domein.nl \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.