From: Hans de Goede <hdegoede@redhat.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [RFCv2 PATCH 01/12] stk-webcam: the initial hflip and vflip setup was the wrong way around
Date: Mon, 11 Feb 2013 14:08:44 +0100 [thread overview]
Message-ID: <5118ED5C.2080801@redhat.com> (raw)
In-Reply-To: <21a2f157a80755483630be6aab26f67dc9f041c6.1360518390.git.hans.verkuil@cisco.com>
Hi,
Subject: stk-webcam: the initial hflip and vflip setup was the wrong way around
No it is not.
On 02/10/2013 06:52 PM, Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> This resulted in an upside-down picture.
No it does not, the laptop having an upside down mounted camera and not being
in the dmi-table is what causes an upside down picture. For a non upside
down camera (so no dmi-match) hflip and vflip should be 0.
The fix for the upside-down-ness Arvydas Sidorenko reported would be to
add his laptop to the upside down table.
Regards,
Hans
next prev parent reply other threads:[~2013-02-11 13:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-10 17:52 [RFCv2 PATCH 00/12] stk-webcam: v4l2-compliance fixes Hans Verkuil
2013-02-10 17:52 ` [RFCv2 PATCH 01/12] stk-webcam: the initial hflip and vflip setup was the wrong way around Hans Verkuil
2013-02-10 17:52 ` [RFCv2 PATCH 02/12] stk-webcam: remove bogus STD support Hans Verkuil
2013-02-10 17:52 ` [RFCv2 PATCH 03/12] stk-webcam: add support for struct v4l2_device Hans Verkuil
2013-02-10 17:52 ` [RFCv2 PATCH 04/12] stk-webcam: convert to the control framework Hans Verkuil
2013-02-10 17:52 ` [RFCv2 PATCH 05/12] stk-webcam: don't use private_data, use video_drvdata Hans Verkuil
2013-02-10 17:52 ` [RFCv2 PATCH 06/12] stk-webcam: add support for control events and prio handling Hans Verkuil
2013-02-10 17:52 ` [RFCv2 PATCH 07/12] stk-webcam: fix querycap and simplify s_input Hans Verkuil
2013-02-10 17:52 ` [RFCv2 PATCH 08/12] stk-webcam: zero the priv field of v4l2_pix_format Hans Verkuil
2013-02-10 17:52 ` [RFCv2 PATCH 09/12] stk-webcam: enable core-locking Hans Verkuil
2013-02-10 17:52 ` [RFCv2 PATCH 10/12] stk-webcam: fix read() handling when reqbufs was already called Hans Verkuil
2013-02-10 17:52 ` [RFCv2 PATCH 11/12] stk-webcam: s_fmt shouldn't grab ownership Hans Verkuil
2013-02-10 17:52 ` [RFCv2 PATCH 12/12] stk-webcam: implement support for count == 0 when calling REQBUFS Hans Verkuil
2013-02-11 13:08 ` Hans de Goede [this message]
2013-02-11 13:21 ` [RFCv2 PATCH 01/12] stk-webcam: the initial hflip and vflip setup was the wrong way around Hans Verkuil
2013-02-11 13:41 ` Hans de Goede
2013-02-11 13:51 ` Hans Verkuil
2013-02-11 14:55 ` Hans de Goede
2013-02-11 15:11 ` Anca Emanuel
2013-02-11 15:32 ` Arvydas Sidorenko
2013-02-12 8:28 ` Hans Verkuil
2013-02-14 8:12 ` Hans Verkuil
2013-02-14 10:13 ` Arvydas Sidorenko
2013-02-12 8:30 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5118ED5C.2080801@redhat.com \
--to=hdegoede@redhat.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.