From: r.sricharan@ti.com (R Sricharan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V6] ARM: LPAE: Fix mapping in alloc_init_section for unaligned addresses
Date: Mon, 11 Feb 2013 18:53:28 +0530 [thread overview]
Message-ID: <5118F0D0.60101@ti.com> (raw)
In-Reply-To: <20130211131230.GA5676@MacBook-Pro.local>
On Monday 11 February 2013 06:42 PM, Catalin Marinas wrote:
> On Mon, Feb 11, 2013 at 09:13:29AM +0000, R Sricharan wrote:
>> +static void __init alloc_init_pmd(pud_t *pud, unsigned long addr,
>> + unsigned long end, phys_addr_t phys,
>> + const struct mem_type *type)
>> +{
>> + pmd_t *pmd = pmd_offset(pud, addr);
>> + unsigned long next;
>> +
>> + do {
>> /*
>> - * No need to loop; pte's aren't interested in the
>> - * individual L1 entries.
>> + * With LPAE, we must loop over to map
>> + * all the pmds for the given range.
>> */
>> - alloc_init_pte(pmd, addr, end, __phys_to_pfn(phys), type);
>> - }
>> + next = pmd_addr_end(addr, end);
>> +
>> + /*
>> + * Try a section mapping - end, addr and phys must all be
>> + * aligned to a section boundary.
>> + */
>
> Should this read "next, addr and phys" instead of "end..."?
>
hmm, correct. will change it now
> Otherwise:
>
> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
>
Regards,
Sricharan
next prev parent reply other threads:[~2013-02-11 13:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 9:13 [PATCH V6] ARM: LPAE: Fix mapping in alloc_init_section for unaligned addresses R Sricharan
2013-02-11 13:12 ` Catalin Marinas
2013-02-11 13:23 ` R Sricharan [this message]
2013-02-11 13:52 ` R Sricharan
2013-02-21 12:26 ` R Sricharan
2013-03-14 3:58 ` Sricharan R
2013-03-15 17:36 ` Russell King - ARM Linux
2013-03-15 18:08 ` Christoffer Dall
2013-03-17 5:00 ` Sricharan R
-- strict thread matches above, loose matches on Subject: below --
2013-03-17 5:05 Sricharan R
2013-03-17 19:52 ` Christoffer Dall
2013-03-18 5:50 ` Sricharan R
2013-03-18 10:45 ` Russell King - ARM Linux
2013-03-18 10:54 ` Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5118F0D0.60101@ti.com \
--to=r.sricharan@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.