Re: Perf record premature termination

[David Ahern <dsahern@gmail.com>]

On 2/11/13 11:50 AM, Tim Chen wrote:
> David,
>
> When I am doing a profiling of kernel compile with 32 threads on a 4
> socket westmere machine, I found that perf record terminated right away
> for the version of perf in 3.7 kernel source tree.
> There's no profile data recroded and the compile is running in
> background.
>
> $ make -j32 &
> then
> $ sudo /test/perf record -a -g -f sleep 5
> sleep: Terminated
>

This should fix it. I guess not all return codes were meant to be checked.


diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index e9231659..7733051 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -645,9 +645,6 @@ static int __cmd_record(struct perf_record *rec, int 
argc, const char **argv)
         err = perf_event__synthesize_threads(tool, 
process_synthesized_event,
                            machine);

-   if (err != 0)
-       goto out_delete_session;
-
     if (rec->realtime_prio) {
         struct sched_param param;