Re: [PATCH] mdadm: fix portability issues encountered while building against musl libc

[John Spencer <maillist-mdadm@barfooze.de>]

On 02/10/2013 05:45 AM, NeilBrown wrote:
>
> Hi,
>   I've applied this one and the GCC #ifdef - thanks.

thanks!

>
>   I haven't applied the last one, but not because I don't appreciate being
>   called insane :-)

he he :)

>
>   I like having -Werror as it encourages people to report any warnings they
>   get, and it keeps me "honest".

well, i dont think anyone except of the author(s) wants that flag 
activated by default so that they can find warnings without looking to 
closely.

>   If it is a problem for you, you can easily
>     make CWFLAGS=

i know, but "broken-by-default" is not a very friendly setting.
there are quite a couple of warnings GCC emits that are simply bogus.
i'd rather if the one that actually wants this hardcore setting uses 
make CWFLAGS=-Werror (or make FATAL=1) instead of forcing his policy on 
all users.

>
>   or set the C Warning FLAGS to whatever you like - they are deliberately kept
>   separate from other CFLAGS.
>
> Thanks,
> NeilBrown


thanks,
--JS