From: Larry Finger <Larry.Finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Catalin Iacob <iacobcatalin@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: Initialize rate_init member of struct rate_control_ops
Date: Mon, 11 Feb 2013 15:48:36 -0600 [thread overview]
Message-ID: <51196734.6050507@lwfinger.net> (raw)
In-Reply-To: <1360618939.8738.50.camel@jlt4.sipsolutions.net>
On 02/11/2013 03:42 PM, Johannes Berg wrote:
> On Mon, 2013-02-11 at 15:37 -0600, Larry Finger wrote:
>
>>> + .rate_init = rtl_rate_init,
>>> .tx_status = rtl_tx_status,
>>> .get_rate = rtl_get_rate,
>>> };
>>
>> Shouldn't rate_control_rate_init() in net/mac80211/rate.h be changed to protect
>> against the oops? I don't see any value in the client driver having to provide a
>> dummy routine. The rtlwifi family of drivers use their own rate-control
>> mechanism, and get no rate-control info from mac80211.
>
> In this case, I see no value in them providing rate control operations
> at all, and they could just set IEEE80211_HW_HAS_RATE_CONTROL, no?
I think that makes sense.
Larry
next prev parent reply other threads:[~2013-02-11 21:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 21:18 [PATCH] rtlwifi: Initialize rate_init member of struct rate_control_ops Catalin Iacob
2013-02-11 21:22 ` Johannes Berg
2013-02-11 21:37 ` Larry Finger
2013-02-11 21:42 ` Johannes Berg
2013-02-11 21:48 ` Larry Finger [this message]
2013-02-11 21:58 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51196734.6050507@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=iacobcatalin@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.