All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Added local directory as soure of kernel code
Date: Tue, 12 Feb 2013 18:15:38 +0100	[thread overview]
Message-ID: <511A78BA.4010200@mind.be> (raw)
In-Reply-To: <1360310725-6463-2-git-send-email-rafal.fabich@gmail.com>

On 08/02/13 09:05, Rafal Fabich wrote:
> In 'menuconfig' user can choose the local directory as a source of Linux kernel code.
> Useful during kernel drivers or modules development.
>
> Tested on three different development machines and different kernel sources.
>
> Signed-off-by: Rafal Fabich <rafal.fabich@gmail.com>

  Looks like this is asked for over and over again, so I think it is 
really worth adding this option. I think this was in fact briefly 
discussed at the BR Developer Days but I didn't write it down in the 
report...

  Between this patch and Richard Braun's, I think this one is closer to 
how it should be.

  One comment below, though.

> ---
>   linux/Config.in |   14 ++++++++++++++
>   linux/linux.mk  |    3 +++
>   2 files changed, 17 insertions(+)
>
> diff --git a/linux/Config.in b/linux/Config.in
> index 3c50acc..d88d920 100644
> --- a/linux/Config.in
> +++ b/linux/Config.in
> @@ -52,6 +52,11 @@ config BR2_LINUX_KERNEL_CUSTOM_GIT
>   	  This option allows Buildroot to get the Linux kernel source
>   	  code from a Git repository.
>
> +config BR2_LINUX_KERNEL_CUSTOM_LOCAL
> +	bool "Local directory"
> +	help
> +	  This option allows Buildroot to get the Linux kernel source
> +	  code from a local directory.
>   endchoice
>
>   config BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE
> @@ -74,6 +79,13 @@ config BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION
>   	  Git revision to use in the format used by git rev-parse,
>   	  E.G. a sha id, a tag, branch, ..
>
> +config BR2_LINUX_KERNEL_CUSTOM_LOCAL_PATH
> +	string "Path to the local directory"
> +	depends on BR2_LINUX_KERNEL_CUSTOM_LOCAL
> +	help
> +	  Path to the local directory with the Linux kernel source code.
> +
> +
>   config BR2_LINUX_KERNEL_VERSION
>   	string
>   	default "3.7.6" if BR2_LINUX_KERNEL_3_7
> @@ -81,6 +93,8 @@ config BR2_LINUX_KERNEL_VERSION
>   	default BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE if BR2_LINUX_KERNEL_CUSTOM_VERSION
>   	default "custom" if BR2_LINUX_KERNEL_CUSTOM_TARBALL
>   	default $BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION if BR2_LINUX_KERNEL_CUSTOM_GIT
> +	default "local" if BR2_LINUX_KERNEL_CUSTOM_LOCAL
> +

  This is a bit confusing, because the 'local' site method will force 
LINUX_VERSION to "custom". So I would call it custom here as well.

  Regards,
  Arnout

>
>   #
>   # Patch selection
> diff --git a/linux/linux.mk b/linux/linux.mk
> index 91a9f50..3f2d460 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -15,6 +15,9 @@ LINUX_SOURCE = $(notdir $(LINUX_TARBALL))
>   else ifeq ($(BR2_LINUX_KERNEL_CUSTOM_GIT),y)
>   LINUX_SITE = $(call qstrip,$(BR2_LINUX_KERNEL_CUSTOM_GIT_REPO_URL))
>   LINUX_SITE_METHOD = git
> +else ifeq ($(BR2_LINUX_KERNEL_CUSTOM_LOCAL),y)
> +LINUX_SITE = $(call qstrip,$(BR2_LINUX_KERNEL_CUSTOM_LOCAL_PATH))
> +LINUX_SITE_METHOD = local
>   else
>   LINUX_SOURCE = linux-$(LINUX_VERSION).tar.bz2
>   # In X.Y.Z, get X and Y. We replace dots and dashes by spaces in order
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  parent reply	other threads:[~2013-02-12 17:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-08  8:05 [Buildroot] [PATCH 1/1] Added local directory as soure of kernel code Rafal Fabich
2013-02-08  8:05 ` Rafal Fabich
2013-02-10 20:50   ` Yann E. MORIN
2013-02-11  8:30     ` Rafał Fabich
2013-02-12 17:15   ` Arnout Vandecappelle [this message]
2013-02-12 21:45     ` Thomas Petazzoni
2013-02-13 16:54     ` Rafał Fabich
2013-02-13 18:08       ` Yann E. MORIN
2013-02-21 18:28   ` Arnout Vandecappelle
2013-02-22  6:06     ` Rafał Fabich
2013-02-23 17:49       ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511A78BA.4010200@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.