From: Tim Gardner <tim.gardner@canonical.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH linux-next] befs: befs_fill_super(): remove unreachable code
Date: Tue, 12 Feb 2013 11:07:36 -0700 [thread overview]
Message-ID: <511A84E8.5090309@canonical.com> (raw)
In-Reply-To: <87halhfms4.fsf@xmission.com>
On 02/12/2013 10:46 AM, Eric W. Biederman wrote:
> Tim Gardner <tim.gardner@canonical.com> writes:
>
>> befs_sb->num_blocks is of base type u64 which is the same as sector_t.
>> Therefore, num_blocks can never be larger then the maximum
>> value of sector_t.
>
> The analysys is wrong. On 32bit with CONFIG_LBAF unset sector_t is an
> unsigned long aka a u32, while befs_off_t is always a u64.
>
> Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Dang - you're right.
--
Tim Gardner tim.gardner@canonical.com
prev parent reply other threads:[~2013-02-12 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 17:34 [PATCH linux-next] befs: befs_fill_super(): remove unreachable code Tim Gardner
2013-02-12 17:46 ` Eric W. Biederman
2013-02-12 18:07 ` Tim Gardner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511A84E8.5090309@canonical.com \
--to=tim.gardner@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.