From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Ozan Çağlayan" <ozancag@gmail.com>
Cc: backports@vger.kernel.org
Subject: Re: [PATCH] compat-drivers: Add possibility to build every subsystem separately
Date: Tue, 12 Feb 2013 22:18:43 +0100 [thread overview]
Message-ID: <511AB1B3.7090909@hauke-m.de> (raw)
In-Reply-To: <CAFub=KQx6wCMUsQJAJXbiaUQ4-uUDepp0datbWuef-Gqst0xnA@mail.gmail.com>
On 02/03/2013 08:19 PM, Ozan Çağlayan wrote:
>>
>> Why are you removing the ifeq ($(BT),) here?
>
> Well I didn't get what it does. (It seems to switch on/off bluetooth
> but not in an intuitive way) Also it was always set to True without
> user's intervention so I removed it to provoke a discussion about its
> functionality :p
I do not get it neither. ;-)
Could you remove it in a separate patch., in the long term it be nice to
deactivate it like gpu and network independently from the other network
stuff.
>> I think it is better to add all (gpu and network) when nothing specific
>> was given, this way the script does the same when the same parameters
>> are given than it did before.
>
> Well yes you are right but then we have to change the parameter logic
> to support disabling subsystems, e.g.
>
> admin-update.sh --disable-network.
Isn't there a away to treat everything as selected if nothing is given
and if something was given just build that particular subsystem.
Hmm, the longer I think about it this also does not sound very nice. I
think your first approach is better, just add the selected subsystems
But a help page should be displayed when nothing was given explaining
what to do.
Hauke
next prev parent reply other threads:[~2013-02-12 21:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-03 18:33 [PATCH] compat-drivers: Add possibility to build every subsystem separately Ozan Çağlayan
2013-02-03 19:10 ` Hauke Mehrtens
2013-02-03 19:19 ` Ozan Çağlayan
2013-02-12 21:18 ` Hauke Mehrtens [this message]
2013-03-12 9:13 ` Ozan Çağlayan
2013-03-12 10:51 ` Luis R. Rodriguez
2013-03-12 12:12 ` Ozan Çağlayan
2013-03-12 20:36 ` Luis R. Rodriguez
2013-03-15 8:48 ` Luis R. Rodriguez
2013-03-15 9:09 ` Ozan Çağlayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511AB1B3.7090909@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=backports@vger.kernel.org \
--cc=ozancag@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.