diff for duplicates of <511AE8A4.4060608@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 069af8b..595027a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,7 +2,8 @@ On 02/12/2013 06:30 PM, Daniel Borkmann wrote: > We walk through the bind address list and try to get the best source > address for a given destination. However, currently, we take the > 'continue' path of the loop when an entry is invalid (!laddr->valid) -> *and* the entry state does not equal SCTP_ADDR_SRC (laddr->state !> SCTP_ADDR_SRC). +> *and* the entry state does not equal SCTP_ADDR_SRC (laddr->state != +> SCTP_ADDR_SRC). > > Thus, still, invalid entries with SCTP_ADDR_SRC might not 'continue' > as well as valid entries with SCTP_ADDR_{NEW, SRC, DEL}, with a possible @@ -35,9 +36,9 @@ Acked-by: Vlad Yasevich <vyasevich@gmail.com> > - if (!laddr->valid && laddr->state != SCTP_ADDR_SRC) > + if (!laddr->valid) > continue; -> - if ((laddr->a.sa.sa_family = AF_INET6) && -> + if ((laddr->state = SCTP_ADDR_SRC) && -> + (laddr->a.sa.sa_family = AF_INET6) && +> - if ((laddr->a.sa.sa_family == AF_INET6) && +> + if ((laddr->state == SCTP_ADDR_SRC) && +> + (laddr->a.sa.sa_family == AF_INET6) && > (scope <= sctp_scope(&laddr->a))) { > bmatchlen = sctp_v6_addr_match_len(daddr, &laddr->a); > if (!baddr || (matchlen < bmatchlen)) { diff --git a/a/content_digest b/N1/content_digest index fa6640b..7fd0171 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\04a07201201d7bac08468d17dea3dbc1ea9a67205.1360709645.git.dborkman@redhat.com\0" "From\0Vlad Yasevich <vyasevich@gmail.com>\0" "Subject\0Re: [PATCH net] net: sctp: sctp_v6_get_dst: fix boolean test in dst cache\0" - "Date\0Wed, 13 Feb 2013 01:13:08 +0000\0" + "Date\0Tue, 12 Feb 2013 20:13:08 -0500\0" "To\0Daniel Borkmann <dborkman@redhat.com>\0" "Cc\0davem@davemloft.net" linux-sctp@vger.kernel.org @@ -13,7 +13,8 @@ "> We walk through the bind address list and try to get the best source\n" "> address for a given destination. However, currently, we take the\n" "> 'continue' path of the loop when an entry is invalid (!laddr->valid)\n" - "> *and* the entry state does not equal SCTP_ADDR_SRC (laddr->state !> SCTP_ADDR_SRC).\n" + "> *and* the entry state does not equal SCTP_ADDR_SRC (laddr->state !=\n" + "> SCTP_ADDR_SRC).\n" ">\n" "> Thus, still, invalid entries with SCTP_ADDR_SRC might not 'continue'\n" "> as well as valid entries with SCTP_ADDR_{NEW, SRC, DEL}, with a possible\n" @@ -46,12 +47,12 @@ "> -\t\tif (!laddr->valid && laddr->state != SCTP_ADDR_SRC)\n" "> +\t\tif (!laddr->valid)\n" "> \t\t\tcontinue;\n" - "> -\t\tif ((laddr->a.sa.sa_family = AF_INET6) &&\n" - "> +\t\tif ((laddr->state = SCTP_ADDR_SRC) &&\n" - "> +\t\t (laddr->a.sa.sa_family = AF_INET6) &&\n" + "> -\t\tif ((laddr->a.sa.sa_family == AF_INET6) &&\n" + "> +\t\tif ((laddr->state == SCTP_ADDR_SRC) &&\n" + "> +\t\t (laddr->a.sa.sa_family == AF_INET6) &&\n" "> \t\t (scope <= sctp_scope(&laddr->a))) {\n" "> \t\t\tbmatchlen = sctp_v6_addr_match_len(daddr, &laddr->a);\n" "> \t\t\tif (!baddr || (matchlen < bmatchlen)) {\n" > -f9511d76c4b602852f8df857e06f3cead4adb6ce4c3dca86eabd6488cf559bae +64fac2c66ce2bc63650f9e205fe760cb4d2e5d7e29cc048b48dada51f9e9adea
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.