From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Larsson Subject: Re: [PATCH v3 5/5] gpio: Make of_count_named_gpios() use new of_count_phandle_with_args() Date: Wed, 13 Feb 2013 11:00:10 +0100 Message-ID: <511B642A.9000004@gaisler.com> References: <1360710401-16757-1-git-send-email-grant.likely@secretlab.ca> <1360710401-16757-6-git-send-email-grant.likely@secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1360710401-16757-6-git-send-email-grant.likely@secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org To: Grant Likely Cc: linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Linus Walleij , Rob Herring List-Id: devicetree@vger.kernel.org On 2013-02-13 00:06, Grant Likely wrote: > This patch replaces the horribly coded of_count_named_gpios() with a > call to of_count_phandle_with_args() which is far more efficient. This > also changes the return value of of_gpio_count() & of_gpio_named_count() > from 'unsigned int' to 'int' so that it can return an error code. All > the users of that function are fixed up to correctly handle a negative > return value. > > v2: Split GPIO portion into a separate patch > > Signed-off-by: Grant Likely > Cc: Linus Walleij > Cc: Rob Herring > Cc: Andreas Larsson For gpiolib-of.c, of_gpio.h and spi.c: Tested-by: Andreas Larsson Cheers, Andreas Larsson