From: Sebastian Riemer <sebastian.riemer@profitbricks.com>
To: NeilBrown <neilb@suse.de>
Cc: Joe Lawrence <Joe.Lawrence@stratus.com>, linux-raid@vger.kernel.org
Subject: Re: Set disk faulty / hot disk remove ioctl bug for read-only MD?
Date: Wed, 13 Feb 2013 12:45:42 +0100 [thread overview]
Message-ID: <511B7CE6.5060806@profitbricks.com> (raw)
In-Reply-To: <20130213133820.6496b074@notabene.brown>
On 13.02.2013 03:38, NeilBrown wrote:
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 8b557d2..292cc2f 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -6529,7 +6529,17 @@ static int md_ioctl(struct block_device *bdev, fmode_t mode,
> mddev->ro = 0;
> sysfs_notify_dirent_safe(mddev->sysfs_state);
> set_bit(MD_RECOVERY_NEEDED, &mddev->recovery);
> - md_wakeup_thread(mddev->thread);
> + /* mddev_unlock will wake thread */
> + /* If a device failed while we were read-only, we
> + * need to make sure the metadata is updated now.
> + */
> + if (test_bit(MD_CHANGE_DEVS, &mddev->flags)) {
> + mddev_unlock(mddev);
> + wait_event(mddev->sb_wait,
> + !test_bit(MD_CHANGE_DEVS, &mddev->flags) &&
> + !test_bit(MD_CHANGE_PENDING, &mddev->flags));
> + mddev_lock(mddev);
> + }
> } else {
> err = -EROFS;
> goto abort_unlock;
>
Thanks, Neil!
I can confirm the issue on 3.4.y and that your patch fixes it reliably.
Acked-by: Sebastian Riemer <sebastian.riemer@profitbricks.com>
next prev parent reply other threads:[~2013-02-13 11:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 21:05 Set disk faulty / hot disk remove ioctl bug for read-only MD? Joe Lawrence
2013-02-13 2:38 ` NeilBrown
2013-02-13 11:45 ` Sebastian Riemer [this message]
2013-02-13 14:30 ` Sebastian Riemer
2013-02-13 21:55 ` NeilBrown
2013-02-14 12:23 ` Sebastian Riemer
2013-02-13 18:56 ` Joe Lawrence
2013-02-13 22:01 ` NeilBrown
2013-02-14 19:45 ` Joe Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511B7CE6.5060806@profitbricks.com \
--to=sebastian.riemer@profitbricks.com \
--cc=Joe.Lawrence@stratus.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.