From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH] ASoC: omap-dmic: Clean up with devm_request_and_ioremap Date: Wed, 13 Feb 2013 14:15:35 +0100 Message-ID: <511B91F7.6020305@ti.com> References: <1360740127-4154-1-git-send-email-s-guiriec@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1360740127-4154-1-git-send-email-s-guiriec@ti.com> Sender: linux-omap-owner@vger.kernel.org To: Sebastien Guiriec Cc: Jarkko Nikula , Liam Girdwood , Mark Brown , linux-omap@vger.kernel.org, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On 02/13/2013 08:22 AM, Sebastien Guiriec wrote: > Clean up dmic code with devm_request_and_ioremap function. Acked-by: Peter Ujfalusi >=20 > Signed-off-by: Sebastien Guiriec > --- > sound/soc/omap/omap-dmic.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) >=20 > diff --git a/sound/soc/omap/omap-dmic.c b/sound/soc/omap/omap-dmic.c > index ba49ccd..77e9e7e 100644 > --- a/sound/soc/omap/omap-dmic.c > +++ b/sound/soc/omap/omap-dmic.c > @@ -493,16 +493,9 @@ static int asoc_dmic_probe(struct platform_devic= e *pdev) > goto err_put_clk; > } > =20 > - if (!devm_request_mem_region(&pdev->dev, res->start, > - resource_size(res), pdev->name)) { > - dev_err(dmic->dev, "memory region already claimed\n"); > - ret =3D -ENODEV; > - goto err_put_clk; > - } > - > - dmic->io_base =3D devm_ioremap(&pdev->dev, res->start, > - resource_size(res)); > + dmic->io_base =3D devm_request_and_ioremap(&pdev->dev, res); > if (!dmic->io_base) { > + dev_err(&pdev->dev, "cannot remap\n"); > ret =3D -ENOMEM; > goto err_put_clk; > } >=20 --=20 P=E9ter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html