From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH] IB/lmx4: silence GCC warning Date: Wed, 13 Feb 2013 14:50:20 +0100 Message-ID: <511B9A1C.6000402@acm.org> References: <1348836538.3626.21.camel@x61.thuisdomein> <201210100923.43927.jackm@dev.mellanox.co.il> <1351504201.1339.4.camel@x61.thuisdomein> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1351504201.1339.4.camel@x61.thuisdomein> Sender: linux-kernel-owner@vger.kernel.org To: Paul Bolle Cc: Jack Morgenstein , Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-rdma@vger.kernel.org On 10/29/12 10:50, Paul Bolle wrote: > On Wed, 2012-10-10 at 09:23 +0200, Jack Morgenstein wrote: >> You could use: >> >> u16 uninitialized_var(vlan); >> >> instead. > > I guess we'd better just wait and see whether uninitialized_var() > survives before discussing your suggestion (see the thread starting at > https://lkml.org/lkml/2012/10/26/508 ). > >> Although this in the special QP data flow, I still prefer to avoid adding extra code (even setting >> initial values at procedure entry). The line above will also do the job. "uninitialized_var" >> is used elsewhere in the driver. See, for example, mlx4_ib_post_send() in the same file (qp.c). (replying to an e-mail of a few months ago) If there are no further objections I'd like to see this patch to go upstream. It fixes an annoying compiler warning and I don't think that this patch has a negative performance impact. Thanks, Bart.