From: Andy Grover <agrover@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: target-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Don't allow multiple TPGs or targets to share a portal
Date: Wed, 13 Feb 2013 14:09:01 -0800 [thread overview]
Message-ID: <511C0EFD.9060702@redhat.com> (raw)
In-Reply-To: <1360787516.13707.59.camel@haakon2.linux-iscsi.org>
On 02/13/2013 12:31 PM, Nicholas A. Bellinger wrote:
> On Fri, 2013-02-08 at 15:05 -0800, Andy Grover wrote:
>> RFC 3720 says "Each Network Portal, as utilized by a given iSCSI Node,
>> belongs to exactly one portal group within that node." therefore
>> iscsit_add_np should not check for existing matching portals, it should
>> just go ahead and try to make the portal, and then kernel_bind() will
>> return the proper error.
>>
>> Signed-off-by: Andy Grover <agrover@redhat.com>
>> ---
>
> NACK. Your interpretation of RFC-3720 is incorrect. There is nothing
> that says that a single IP address cannot be shared across multiple
> TargetName+TargetPortalGroupTag endpoints.
A Network Portal is ip:port, not just IP. I'd agree two TPGs can use the
same IP as long as they listen on different ports.
But that bit I quoted seems pretty clear. How should it be alternatively
interpreted?
Thanks -- Andy
next prev parent reply other threads:[~2013-02-13 22:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 0:47 IP_FREEBIND and binding to in-use addr:ports Andy Grover
2013-02-07 18:42 ` Andy Grover
2013-02-08 23:05 ` [PATCH] Don't allow multiple TPGs or targets to share a portal Andy Grover
2013-02-13 20:31 ` Nicholas A. Bellinger
2013-02-13 22:09 ` Andy Grover [this message]
2013-02-15 15:46 ` Nicholas A. Bellinger
2013-02-18 22:41 ` Andy Grover
2013-02-19 4:34 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511C0EFD.9060702@redhat.com \
--to=agrover@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=netdev@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.