From: Zoltan Kiss <zoltan.kiss@citrix.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Frediano Ziglio <frediano.ziglio@citrix.com>
Subject: Re: tcp_use_frto crashes on empty tcp_write_queue
Date: Wed, 13 Feb 2013 22:14:17 +0000 [thread overview]
Message-ID: <511C1039.9020001@citrix.com> (raw)
In-Reply-To: <1360791453.6884.34.camel@edumazet-glaptop>
Hi,
On 13/02/13 21:37, Eric Dumazet wrote:
> This doesn't seem to be a standard kernel.
Indeed, this is a XenServer 6.0.2 kernel, which contains changes,
however the TCP parts are barely modified. The related code path were
not changed.
I'm trying to determine if this bug could be fixed in an obvious way, so
let me rephrase my question: if the socket write queue is empty,
shouldn't we just stop going further instead of dropping a WARN? Or, if
there is a reason to do so, shouldn't we check at least that returned
pointer in tcp_use_frto()?
Regards,
Zoltan Kiss
next prev parent reply other threads:[~2013-02-13 22:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 21:09 tcp_use_frto crashes on empty tcp_write_queue Zoltan Kiss
2013-02-13 21:37 ` Eric Dumazet
2013-02-13 22:14 ` Zoltan Kiss [this message]
2013-02-13 23:24 ` Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2013-02-13 21:06 Zoltan Kiss
2013-02-13 21:10 ` Zoltan Kiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511C1039.9020001@citrix.com \
--to=zoltan.kiss@citrix.com \
--cc=eric.dumazet@gmail.com \
--cc=frediano.ziglio@citrix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.