All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 3/3] Tegra: MMC: Add DT support to MMC driver for all T20 boards
Date: Wed, 13 Feb 2013 17:17:12 -0700	[thread overview]
Message-ID: <511C2D08.6010303@wwwdotorg.org> (raw)
In-Reply-To: <1360791890-6644-4-git-send-email-twarren@nvidia.com>

On 02/13/2013 02:44 PM, Tom Warren wrote:
> tegra_mmc_init() now parses the DT info for bus width, WP/CD GPIOs, etc.
> Tested on Seaboard, fully functional.
> 
> Tamonten boards (medcom-wide, plutux, and tec) use a different/new
> dtsi file w/common settings.

> diff --git a/board/compulab/trimslice/trimslice.c b/board/compulab/trimslice/trimslice.c

> +#ifdef	CONFIG_TEGRA_MMC

It seems a little odd to add this ifdef when it's know that config
option is enabled in the trimslice config file. I can somewhat
understand leaving the ifdef in any other board files that already had
it, but actively adding it here seems strange.

> diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c

> @@ -184,7 +187,6 @@ int board_init(void)
>  	/* prepare the WB code to LP0 location */
>  	warmboot_prepare_code(TEGRA_LP0_ADDR, TEGRA_LP0_SIZE);
>  #endif
> -
>  	return 0;
>  }

Unrelated change?

> diff --git a/drivers/mmc/tegra_mmc.c b/drivers/mmc/tegra_mmc.c
> +static int process_nodes(const void *blob, int node_list[], int count)

> +		/* Mark position as used */
> +		node_list[i] = -1;

Is this actually necessary?

I'll try and test these patches on all the Tegra20 boards I have tomorrow.

  reply	other threads:[~2013-02-14  0:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-13 21:44 [U-Boot] [PATCH v3 0/3] Tegra: MMC: Add DT support for MMC to T20 boards Tom Warren
2013-02-13 21:44 ` [U-Boot] [PATCH v3 1/3] Tegra: fdt: Add/enhance sdhci (mmc) nodes for all T20 DT files Tom Warren
2013-02-14  0:10   ` Stephen Warren
2013-02-14 16:14     ` Tom Warren
2013-02-14 20:24       ` Stephen Warren
2013-02-15 11:58         ` Lucas Stach
2013-02-20 18:04           ` Tom Warren
2013-02-13 21:44 ` [U-Boot] [PATCH v3 2/3] Tegra: fdt: tamonten: Add common tamonten.dtsi file from linux Tom Warren
2013-02-14  0:11   ` Stephen Warren
2013-02-14  7:18   ` Thierry Reding
2013-02-13 21:44 ` [U-Boot] [PATCH v3 3/3] Tegra: MMC: Add DT support to MMC driver for all T20 boards Tom Warren
2013-02-14  0:17   ` Stephen Warren [this message]
2013-02-14  4:47     ` Simon Glass
2013-02-14 15:42     ` Tom Warren
2013-02-14  7:19 ` [U-Boot] [PATCH v3 0/3] Tegra: MMC: Add DT support for MMC to " Thierry Reding
2013-02-14 15:33   ` Tom Warren
2013-02-14 19:25   ` Thierry Reding
2013-02-14 23:27 ` Stephen Warren
2013-02-14 23:33   ` Tom Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511C2D08.6010303@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.