All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH] xen-blkback: use balloon pages for persistent grants
Date: Thu, 14 Feb 2013 11:56:37 +0100	[thread overview]
Message-ID: <511CC2E5.4090400@citrix.com> (raw)
In-Reply-To: <1360836729-17874-1-git-send-email-roger.pau@citrix.com>

On 14/02/13 11:12, Roger Pau Monne wrote:
> With current persistent grants implementation we are not freeing the
> persistent grants after we disconnect the device. Since grant map
> operations change the mfn of the allocated page, and we can no longer
> pass it to __free_page without setting the mfn to a sane value, use
> balloon grant pages instead, as the gntdev device does.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Cc: xen-devel@lists.xen.org
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

I think this patch is missing the following change in Kconfig, but 
gntdev doesn't depend on the balloon driver, which it also uses, so I'm 
not sure.

---
diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index f529407..74e2415 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -488,7 +488,7 @@ config XEN_BLKDEV_FRONTEND
 
 config XEN_BLKDEV_BACKEND
 	tristate "Xen block-device backend driver"
-	depends on XEN_BACKEND
+	depends on XEN_BACKEND && XEN_BALLOON
 	help
 	  The block-device backend driver allows the kernel to export its
 	  block devices to other guests via a high-performance shared-memory




  parent reply	other threads:[~2013-02-14 10:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-14 10:12 [PATCH] xen-blkback: use balloon pages for persistent grants Roger Pau Monne
2013-02-14 10:56 ` Roger Pau Monné
2013-02-14 10:56 ` Roger Pau Monné [this message]
2013-02-14 13:23 ` Konrad Rzeszutek Wilk
2013-02-14 13:23 ` Konrad Rzeszutek Wilk
2013-02-14 15:02   ` Roger Pau Monné
2013-02-14 15:02   ` Roger Pau Monné
2013-02-15  2:52     ` Konrad Rzeszutek Wilk
2013-02-15  2:52     ` Konrad Rzeszutek Wilk
  -- strict thread matches above, loose matches on Subject: below --
2013-02-14 10:12 Roger Pau Monne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511CC2E5.4090400@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.