All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Knoth <adi@drcomp.erfurt.thur.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: Allocating DMA buffer for non-PCM
Date: Thu, 14 Feb 2013 18:26:53 +0100	[thread overview]
Message-ID: <511D1E5D.30709@drcomp.erfurt.thur.de> (raw)
In-Reply-To: <s5hy5eqstrb.wl%tiwai@suse.de>

On 02/14/2013 06:14 PM, Takashi Iwai wrote:

>> 	/* allocate level buffer */
>> 	err = snd_dma_alloc_pages(SNDRV_DMA_TYPE_DEV_SG,
>> 			snd_dma_pci_data(hdspm->pci),
>> 			MADIFX_LEVEL_BUFFER_SIZE, &hdspm->dmaLevelBuffer);
>> 	if (err < 0) {
>>     /* error */ [..]
>>     }
>>
>>     hdspm->level_buffer = snd_sgbuf_get_ptr(&(hdspm->dmaLevelBuffer), 0);
> 
> hdspm->level_buffer = (u32*)hdspm.dmaLevelBuffer.area;

Looks good, TNX.

>> This used to work on my development machine (kernel 3.6.x), but now a
>> kernel 3.2.0 user reports a NULL pointer dereference of
>> hdspm->level_buffer, so apparently, snd_sgbuf_get_ptr() returned NULL
>> for him.
> What's level_buffer?

The card does hardware metering and stores RMS/peak values in a DMA
buffer. I want to later pass this to userspace to show signal levels,
either via memcpy()ing the DMA buffer or maybe via mmap(). But since I
no longer have access to such a card, work on this is on halt atm.

> Is a SG-buffer for the audio stream?

The audio buffers use

	     snd_pcm_lib_preallocate_pages_for_all(pcm,
						   SNDRV_DMA_TYPE_DEV_SG,
						   snd_dma_pci_data(hdspm->pci),


so they're SG, yes.

>> How could this possibly happen?
> A wrong usage :)

I thought so, that's why I was asking. ;)



Cheers and thanks again

  reply	other threads:[~2013-02-14 17:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-14 17:03 Allocating DMA buffer for non-PCM Adrian Knoth
2013-02-14 17:14 ` Takashi Iwai
2013-02-14 17:26   ` Adrian Knoth [this message]
2013-02-15  6:22     ` Takashi Iwai
2013-02-14 17:46 ` Clemens Ladisch
2013-02-14 17:52   ` Adrian Knoth
2013-02-14 18:01     ` Clemens Ladisch
2013-02-14 18:46       ` Adrian Knoth
2013-02-15  9:04         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511D1E5D.30709@drcomp.erfurt.thur.de \
    --to=adi@drcomp.erfurt.thur.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.