From: "Arend van Spriel" <arend@broadcom.com>
To: "Joe Perches" <joe@perches.com>
Cc: "Pieter-Paul Giesberts" <pieterpg@broadcom.com>,
brcm80211-dev-list@broadcom.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] brcmsmac: Remove unnecessary memset casts
Date: Thu, 14 Feb 2013 20:56:28 +0100 [thread overview]
Message-ID: <511D416C.5070802@broadcom.com> (raw)
In-Reply-To: <6b2fcef4f4983542d3fd08005cfe06d7cd82e97e.1360805256.git.joe@perches.com>
On 02/14/2013 02:33 AM, Joe Perches wrote:
> Remove the casts of the first argument of memset.
>
> Neaten the style by using the sizeof the actual variable
> being memset not the sizeof the type of variable.
Acked-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/net/wireless/brcm80211/brcmsmac/main.c | 23 ++++++++++-------------
> 1 file changed, 10 insertions(+), 13 deletions(-)
For new code we try to stick to that style. Thanks for going through the
existing code.
Gr. AvS
next prev parent reply other threads:[~2013-02-14 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 1:33 [PATCH 1/2] brcmsmac: Downgrade d11hdrs_mac80211 error messages to warnings Joe Perches
2013-02-14 1:33 ` [PATCH 2/2] brcmsmac: Remove unnecessary memset casts Joe Perches
2013-02-14 19:56 ` Arend van Spriel [this message]
2013-02-14 19:54 ` [PATCH 1/2] brcmsmac: Downgrade d11hdrs_mac80211 error messages to warnings Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511D416C.5070802@broadcom.com \
--to=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pieterpg@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.