Re: [PATCH 1/2] mmc: dw_mmc: exynos: Add compatibility for exynos4412 SoC

[Jaehoon Chung <jh80.chung@samsung.com>]

On 02/15/2013 02:09 PM, Alim Akhtar wrote:
> Hi Sachin,
> 
> On Thu, Feb 14, 2013 at 8:55 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> On 07/02/2013, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>>> Added compatibility string for Exynos4412 SoC.
>>>
>>> Cc: Thomas Abraham <thomas.abraham@linaro.org>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>
>> Any comments on this patch?
>>
>>> ---
>>>  drivers/mmc/host/dw_mmc-exynos.c |    2 ++
>>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/mmc/host/dw_mmc-exynos.c
>>> b/drivers/mmc/host/dw_mmc-exynos.c
>>> index 72fd0f2..f15b4d3 100644
>>> --- a/drivers/mmc/host/dw_mmc-exynos.c
>>> +++ b/drivers/mmc/host/dw_mmc-exynos.c
>>> @@ -209,6 +209,8 @@ static const struct dw_mci_drv_data exynos5250_drv_data
>>> = {
>>>  };
>>>
>>>  static const struct of_device_id dw_mci_exynos_match[] = {
>>> +     { .compatible = "samsung,exynos4412-dw-mshc",
>>> +                     .data = &exynos5250_drv_data, },
>>>       { .compatible = "samsung,exynos5250-dw-mshc",
>>>                       .data = &exynos5250_drv_data, },
>>>       {},
> 
> Looks like dw_mci_drv_data is a generic enough to be used for all
> exynos SoCs including exynos4210. My thought is, if 4412 and 5250 is
> using the same drv_data(please check 4210 once), let rename them as
> exynos. In that case we still have different compatible name and not
> so __confusing__ .data field.
I agreed Alim's opinion. Actually, i mentioned this point at the Dongin's patch.
If using same drv_data, i would prefer to use "&exynos_drv_data" instead of &exynos5250_drv_data.

This patch could be separated into two patches. like this "compatibility for exynos4412 SOC" and "rename the drv_data"

Best Regards,
Jaehoon Chung
> I am ok if maintainers suggested something else/better here.
>>>
>>> 1.7.4.1
>>>
>>>
>>
>>
>> --
>> With warm regards,
>> Sachin
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html