From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [RFC/NOT FOR MERGING 2/3] serial: omap: remove hwmod dependency Date: Fri, 15 Feb 2013 18:56:47 +0530 Message-ID: <511E3797.2070802@ti.com> References: <1360840554-26901-1-git-send-email-balbi@ti.com> <1360840554-26901-2-git-send-email-balbi@ti.com> <20130214171253.GC7144@atomide.com> <20130214175650.GA25891@arwen.pp.htv.fi> <20130214181217.GA11806@atomide.com> <20130214192719.GB26679@arwen.pp.htv.fi> <20130214193911.GD11806@atomide.com> <20130215101610.GR17852@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:33622 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756498Ab3BONZa (ORCPT ); Fri, 15 Feb 2013 08:25:30 -0500 In-Reply-To: <20130215101610.GR17852@n2100.arm.linux.org.uk> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Russell King - ARM Linux Cc: Paul Walmsley , Tony Lindgren , Linux OMAP Mailing List , Felipe Balbi , Linux ARM Kernel Mailing List Russell, On Friday 15 February 2013 03:46 PM, Russell King - ARM Linux wrote: > On Thu, Feb 14, 2013 at 08:47:53PM +0000, Paul Walmsley wrote: [..] > >> So instead of something bus-specific like that, a better way would be to >> use something like: >> >> va = dev->bus->ioremap( ... ); >> va = dev->bus->iounmap( ... ); > > No. ioremap() is already generic. We don't need additional layers of > indirection per bus type. > Whats your view on use of arch_ioremap_caller() hook ? This can allow us to avoid the dual ioremap() issue discussed here if the hook maintains the list of mapped ios. I was even thinking of having such intelligence within the core ioremap code but thought that might be too invasive. Regards, Santosh From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Fri, 15 Feb 2013 18:56:47 +0530 Subject: [RFC/NOT FOR MERGING 2/3] serial: omap: remove hwmod dependency In-Reply-To: <20130215101610.GR17852@n2100.arm.linux.org.uk> References: <1360840554-26901-1-git-send-email-balbi@ti.com> <1360840554-26901-2-git-send-email-balbi@ti.com> <20130214171253.GC7144@atomide.com> <20130214175650.GA25891@arwen.pp.htv.fi> <20130214181217.GA11806@atomide.com> <20130214192719.GB26679@arwen.pp.htv.fi> <20130214193911.GD11806@atomide.com> <20130215101610.GR17852@n2100.arm.linux.org.uk> Message-ID: <511E3797.2070802@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Russell, On Friday 15 February 2013 03:46 PM, Russell King - ARM Linux wrote: > On Thu, Feb 14, 2013 at 08:47:53PM +0000, Paul Walmsley wrote: [..] > >> So instead of something bus-specific like that, a better way would be to >> use something like: >> >> va = dev->bus->ioremap( ... ); >> va = dev->bus->iounmap( ... ); > > No. ioremap() is already generic. We don't need additional layers of > indirection per bus type. > Whats your view on use of arch_ioremap_caller() hook ? This can allow us to avoid the dual ioremap() issue discussed here if the hook maintains the list of mapped ios. I was even thinking of having such intelligence within the core ioremap code but thought that might be too invasive. Regards, Santosh