Re: [PATCH 5/6] ath6kl: Fix a debugfs crash for USB devices

[Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>]

On 02/15/2013 05:13 PM, Kalle Valo wrote:
> Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com> writes:
>
>>>> +	if (ar->hif_type != ATH6KL_HIF_TYPE_SDIO)
>>>> +		return -EINVAL;
>>>
>>> Actually I think it would be better not to even create the debugfs when
>>> using sdio.
>
> Oops, meant of course s/debugfs/debugfs file/. There seems to be packet
> loss between my brains and fingers...

yeah I think its USB and debugfs file :)

>
>> agreed, but looks bit ugly right ? thoughts.
>
> Sorry, but I don't understand how not creating the debugfs file for usb
> would be ugly? But this isn't that important, if you want we can do it
> like you propose as well.
>

I will cook up a new patch, please see if that's fine :)

-- 
thanks,
shafi