From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Fantoni Subject: Re: [PATCH] tools/libxl: Added vga parameter for hvm domUs Date: Fri, 15 Feb 2013 22:54:49 +0100 Message-ID: <511EAEA9.5040109@heliman.it> References: <1360580242-4972-1-git-send-email-fantonifabio@tiscali.it> <20766.22732.806518.892544@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20766.22732.806518.892544@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com, Stefano.Stabellini@eu.citrix.com, fantonifabio@tiscali.it List-Id: xen-devel@lists.xenproject.org Il 15/02/2013 16:48, Ian Jackson ha scritto: > fantonifabio@tiscali.it writes ("[Xen-devel] [PATCH] tools/libxl: Added vga parameter for hvm domUs"): >> From: Fabio Fantoni >> >> Usage: >> vga="stdvga"|"cirrus" >> >> - Default option is cirrus. >> - Prints error and exit if unknown value is passed. >> - stdvga parameter is now deprecated. >> - Updated xl.cfg man. >> >> Required patch: Improve videoram setting v5 >> Is prerequisite for patch: Add qxl support v9 > The code looks good to me, but there are a couple of formatting > problems. Your wrapping of the longer lines is odd (particularly, you > fail to indent the continuations), and there's a spurious space after > xlu_cfg_get_string. Can you please repost following the style used > elsewhere ? > > Thanks, > Ian. Sorry. Can you explain me the error of indentation did I do please?