From: Stephen Warren <swarren@wwwdotorg.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-tegra@vger.kernel.org,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH] Input: tegra-kbc - assume CONFIG_OF, remove platform data
Date: Fri, 15 Feb 2013 15:48:58 -0700 [thread overview]
Message-ID: <511EBB5A.3030403@wwwdotorg.org> (raw)
In-Reply-To: <20130215224203.GB15811@core.coreip.homeip.net>
On 02/15/2013 03:42 PM, Dmitry Torokhov wrote:
> Hi Stephen,
>
> On Fri, Feb 15, 2013 at 02:58:26PM -0700, Stephen Warren wrote:
>>
>> - irq = platform_get_irq(pdev, 0);
>> - if (irq < 0) {
>> + kbc->irq = platform_get_irq(pdev, 0);
>> + if (kbc->irq < 0) {
>> dev_err(&pdev->dev, "failed to get keyboard IRQ\n");
>> return -ENXIO;
>> }
>
> ikbc->irq is unsigned int so this change is not correct.
>
> I am also getting rejects when I try to apply this, am I missing some
> other patch?
I also have a patch from the Tegra tree in my local tree which changes
one of the clock-related includes. I'll rebase onto your /next tree
directly, fix the irq issue, and repost.
prev parent reply other threads:[~2013-02-15 22:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 21:58 [PATCH] Input: tegra-kbc - assume CONFIG_OF, remove platform data Stephen Warren
[not found] ` <1360965506-19641-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-02-15 22:42 ` Dmitry Torokhov
2013-02-15 22:48 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511EBB5A.3030403@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.