From: Jan Kiszka <jan.kiszka@web.de>
To: Nadav Har'El <nyh@math.technion.ac.il>
Cc: Gleb Natapov <gleb@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>,
"Nakajima, Jun" <jun.nakajima@intel.com>
Subject: Re: [PATCH] KVM: nVMX: Fix injection of PENDING_INTERRUPT and NMI_WINDOW exits to L1
Date: Sat, 16 Feb 2013 15:55:21 +0100 [thread overview]
Message-ID: <511F9DD9.5010001@web.de> (raw)
In-Reply-To: <20130216144617.GA3253@fermat.math.technion.ac.il>
[-- Attachment #1: Type: text/plain, Size: 851 bytes --]
On 2013-02-16 15:46, Nadav Har'El wrote:
> On Sat, Feb 16, 2013, Jan Kiszka wrote about "Re: [PATCH] KVM: nVMX: Fix injection of PENDING_INTERRUPT and NMI_WINDOW exits to L1":
>> No, this is wrong. I first wrote a patch that ignored enable_irq_window
>> when the guest is not interested in external IRQs. But then I thought
>> that wasn't correct. I tend to believe now my first idea was better.
>
> If you want to make the !PIN_BASED_EXT_INTR_MASK case work correctly,
> please also see:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=53711
Yes, I already realized that there is more broken. Trying to find a way
to fix this ATM. That specifically means deciding when to execute
vmx_complete/cancel_interrupts and when not.
This patch seems correct now, just insufficient to make direct injection
from L0 to L2 work.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
prev parent reply other threads:[~2013-02-16 14:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 11:51 [PATCH] KVM: nVMX: Fix injection of PENDING_INTERRUPT and NMI_WINDOW exits to L1 Jan Kiszka
2013-02-16 12:08 ` Jan Kiszka
2013-02-16 14:46 ` Nadav Har'El
2013-02-16 14:55 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511F9DD9.5010001@web.de \
--to=jan.kiszka@web.de \
--cc=gleb@redhat.com \
--cc=jun.nakajima@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=nyh@math.technion.ac.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.