All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Durgin <josh.durgin@inktank.com>
To: Alex Elder <elder@inktank.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH 0/2] libceph: get rid of unused "one shot" event support
Date: Sat, 16 Feb 2013 15:50:08 -0800	[thread overview]
Message-ID: <51201B30.10002@inktank.com> (raw)
In-Reply-To: <511FB598.50603@inktank.com>

On 02/16/2013 08:36 AM, Alex Elder wrote:
> The osd client supports a "one shot" event, but nobody ever uses
> it.  It probably works right, but it's effectively dead code, so
> just get rid of it.  Get rid of ceph_osd_wait_event() as well,
> because whatever purpose it served was probably related to
> using a one shot event.
>
> 					-Alex
>
> [PATCH 1/2] libceph: kill ceph_osdc_create_event() "one_shot"
> [PATCH 2/2] libceph: kill ceph_osdc_wait_event()

These look good.
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>


      parent reply	other threads:[~2013-02-16 23:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-16 16:36 [PATCH 0/2] libceph: get rid of unused "one shot" event support Alex Elder
2013-02-16 16:37 ` [PATCH 1/2] libceph: kill ceph_osdc_create_event() "one_shot" parameter Alex Elder
2013-02-16 16:38 ` [PATCH 2/2] libceph: kill ceph_osdc_wait_event() Alex Elder
2013-02-16 23:50 ` Josh Durgin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51201B30.10002@inktank.com \
    --to=josh.durgin@inktank.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=elder@inktank.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.